Rust 1.57 #586
Merged
Rust 1.57 #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Ojeda <[email protected]>
Probably caused by rust-lang/rust#89030 and rust-lang/rust#89036. I suspect previously it would have failed to compile if the function was actually codegened, just not when defined. Is |
|
That seems to be the case indeed -- I just force-called it from 1.56.0 and got the error. Thanks! |
nbdd0121
reviewed
Dec 2, 2021
Signed-off-by: Miguel Ojeda <[email protected]>
Signed-off-by: Miguel Ojeda <[email protected]>
Suggested-by: bjorn3 <[email protected]> Suggested-by: Gary Guo <[email protected]> Signed-off-by: Miguel Ojeda <[email protected]>
`vec!` may allocate, which in turn requires the `exchange_malloc` `lang_item`. For some reason, in 1.56.0 this compiled. Signed-off-by: Miguel Ojeda <[email protected]>
This triggered a new Clippy lint in 1.57.0. Signed-off-by: Miguel Ojeda <[email protected]>
Signed-off-by: Miguel Ojeda <[email protected]>
Signed-off-by: Miguel Ojeda <[email protected]>
bjorn3
approved these changes
Dec 2, 2021
nbdd0121
approved these changes
Dec 2, 2021
alex
approved these changes
Dec 2, 2021
|
Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the individual commits.
I am particularly curious why
vec!was compiling in 1.56.0 (@bjorn3?).v2:
build_errorupdated here too: cb94e38vec!disabled: 2d5e1de@wedsonaf Please take a look at the
sysctlchange.Fixes #585.