Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated bindgen version. #22

Merged
merged 1 commit into from
Jan 14, 2019

Conversation

azriel91
Copy link
Contributor

Just some maintenance -- trying to bump dependencies. I haven't got a Mac to test this on so would need someone to test this.

The code change is based on:

Would like to update coreaudio-rs as well after this

@mitchmindtree
Copy link
Member

Thanks a lot @azriel91!

Unfortunately I don't have a mac to test this on either atm - might leave this open until a kind soul with a mac drops by and gives this a test :)

@est31
Copy link
Member

est31 commented Oct 18, 2018

IIRC @reuben has had a problem with a too old bindgen version. Maybe they'd be available to test it?

@ghost
Copy link

ghost commented Oct 19, 2018

i tested this per @azriel91's instructions

  1. clone coreaudio-rs
  2. point coreaudio-rs at this branch of coreaudio-sys
    • Compiling coreaudio-sys v0.2.2 (https://github.com/azriel91/coreaudio-sys.git?branch=maintenance/bump-bindgen-version#129d9577)
  3. run cargo run --example sine in coreaudio-rs

it worked fine (made a tone audibly) on OSX Yosemite 10.10.5 with stable rustc 1.29.2 (17a9dc751 2018-10-05) and nightly rustc 1.31.0-nightly (e7f5d4805 2018-10-18)

@Rhuagh
Copy link
Collaborator

Rhuagh commented Oct 19, 2018

Works on 10.13.5 for me with both stable and nightly.

@Rhuagh Rhuagh merged commit 51e90d8 into RustAudio:master Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants