Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated version to 0.2.10 #59

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Conversation

simlay
Copy link
Member

@simlay simlay commented Apr 18, 2022

Follow up from #54.

@simlay simlay requested a review from MichaelHills April 18, 2022 03:46
Copy link
Contributor

@MichaelHills MichaelHills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks fine, is the failing macOS nightly check anything to worry about?

@est31
Copy link
Member

est31 commented Apr 18, 2022

error: reference to packed field is unaligned
 --> /Users/runner/work/coreaudio-sys/coreaudio-sys/target/debug/build/coreaudio-sys-a84fa5dfbcccf0c4/out/coreaudio.rs:3:128047
  |
3 | ...ingify ! (wide))) ; assert_eq ! (unsafe { & (* (:: std :: ptr :: null :: < wide > ())) . lo as * const _ as usize } , 0usize , concat ...
  |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[deny(unaligned_references)]` on by default
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
  = note: for more information, see issue #82523 <https://github.com/rust-lang/rust/issues/82523>

Seems kinda serious to me. This is among a ton of warnings. I guess they are all in the bindgen generated tests, at which point it might be interesting to maybe create a bindgen isue (if there isn't one already).

@simlay does cargo test work for you locally?

@simlay
Copy link
Member Author

simlay commented Apr 18, 2022

Seems kinda serious to me. This is among a ton of warnings. I guess they are all in the bindgen generated tests, at which point it might be interesting to maybe create a bindgen isue (if there isn't one already).

@simlay does cargo test work for you locally?

Interesting. Yeah, cargo +nightly test --all-feature fails. This issue is tracked in rust-lang/rust#82523 and rust-lang/rust-bindgen#1651. I think that in rust nightly, that warning is now a hard error. cargo +beta test --all-features does pass though.

Should we choose to do the quick fix of simply removing nightly from CI, I think we will end up with actual errors with rust 1.62 in ~10 weeks.

I can't say that bindgen has always had lots of warnings but as the compiler has grown, it's added more and more warnings to enable better safety and so that's there's so many.

Anyway, it's unclear what the correct work around is as this is explicitly in the generated unit tests.

@est31
Copy link
Member

est31 commented Apr 18, 2022

Oh no, I hope they revert rust-lang/rust#95372 , at least until there is a solution for it on stable.

@est31
Copy link
Member

est31 commented Apr 18, 2022

There aren't any real tests except for the ones generated by bindgen, whose failing is beyond our control, so maybe one can switch to cargo build instead of cargo test in the CI? Personally I believe that they will either revert that PR or fix bindgen, one of the two will happen, or at least I hope. Edit: but until then one has to find a solution, and that could be just doing cargo build.

@simlay simlay merged commit 26a354b into RustAudio:master Apr 19, 2022
@simlay simlay deleted the bump.-version-to-0.9.10 branch April 19, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants