-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aes-gcm: make AesGcm generic around nonce size #126
Conversation
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
==========================================
+ Coverage 96.26% 96.98% +0.71%
==========================================
Files 28 28
Lines 697 730 +33
==========================================
+ Hits 671 708 +37
+ Misses 26 22 -4
Continue to review full report at Codecov.
|
The test vectors still pass for 96-bit nonces, however there aren't any for non-96-bit nonces, and I'm not convinced this is correct yet, namely this part: It appears after inputting a zero-padded non-96-bit nonce into GHASH, it should also be followed by its length. Regardless, we should add test vectors for non-96-bit nonces. |
d8d2685
to
0b0a23f
Compare
0b0a23f
to
fb163e4
Compare
I added some tests for non-96-bit IVs based on the NIST CAVS vectors and they're presently failing, even after attempting to include the IV length in the GHASH message. |
fb163e4
to
a128b93
Compare
Support for non-96-bit nonces, while still implementing the current `Aead` interface and type safety for nonce lengths.
a128b93
to
4dae48b
Compare
Ok, got it working after updating the CTR implementation to parse a base counter value from 𝐉₀ |
Support for non-96-bit nonces, while still implementing the current
Aead
interface and type safety for nonce lengths.