ecdsa: fix 32-bit builds for the dev feature (#177)

They weren't tested before. They are now!
RustCrypto · Sep 28, 2020 · a404deb · a404deb
1 parent cc78368
commit a404deb
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 4 deletions.
diff --git a/.github/workflows/ecdsa.yml b/.github/workflows/ecdsa.yml
@@ -36,12 +36,13 @@ jobs:
           override: true
       - run: cargo build --no-default-features --release --target ${{ matrix.target }}
       - run: cargo build --no-default-features --release --target ${{ matrix.target }} --features arithmetic
+      - run: cargo build --no-default-features --release --target ${{ matrix.target }} --features dev
       - run: cargo build --no-default-features --release --target ${{ matrix.target }} --features digest
       - run: cargo build --no-default-features --release --target ${{ matrix.target }} --features hazmat
       - run: cargo build --no-default-features --release --target ${{ matrix.target }} --features sign
       - run: cargo build --no-default-features --release --target ${{ matrix.target }} --features verify
       - run: cargo build --no-default-features --release --target ${{ matrix.target }} --features zeroize
-      - run: cargo build --no-default-features --release --target ${{ matrix.target }} --features arithmetic,digest,hazmat,sign,verify,zeroize
+      - run: cargo build --no-default-features --release --target ${{ matrix.target }} --features arithmetic,dev,digest,hazmat,sign,verify,zeroize
 
   test:
     runs-on: ubuntu-latest
@@ -56,6 +57,7 @@ jobs:
         with:
           profile: minimal
           toolchain: ${{ matrix.rust }}
+          override: true
       - run: cargo check --all-features
       - run: cargo test --no-default-features
       - run: cargo test

diff --git a/Cargo.lock b/Cargo.lock
diff --git a/ecdsa/Cargo.toml b/ecdsa/Cargo.toml
@@ -19,7 +19,7 @@ hmac = { version = "0.9", optional = true, default-features = false }
 signature = { version = ">= 1.2.2, < 1.3.0", default-features = false, features = ["rand-preview"] }
 
 [dev-dependencies]
-hex-literal = "0.3"
+hex-literal = "0.2"
 sha2 = { version = "0.9", default-features = false }
 
 [features]

diff --git a/ecdsa/src/dev/curve.rs b/ecdsa/src/dev/curve.rs
@@ -97,6 +97,11 @@ impl Field for Scalar {
 
 impl PrimeField for Scalar {
     type Repr = FieldBytes;
+
+    #[cfg(target_pointer_width = "32")]
+    type ReprBits = [u32; 8];
+
+    #[cfg(target_pointer_width = "64")]
     type ReprBits = [u64; 4];
 
     const NUM_BITS: u32 = 256;