-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update elliptic-curve and digest #433
Conversation
8549184
to
38c3786
Compare
@daxpedda you should be able to update this to use https://github.com/RustCrypto/traits.git as the upstream repo, and pin the |
Done. |
Note that MSRV is now 1.57. |
I had to change the CI a bit because I excluded ed25519 from the workspace, I hope that's alright. |
Why did you need to exclude it from the workspace? All three crates in the workspace are 2021 edition crates. |
I don't know any way to resolve it otherwise. |
Aha, makes sense |
This builds on RustCrypto/traits#883.
The changes are minimal,a lot of added where bounds because ofHmac
and changedInvert
s associated typeOutput
toCtOption<T>
.
Currently there is an issue with having ring-compat reference a different version of signature then what the workspace has: ``` error: failed to select a version for `signature`. ... required by package `ecdsa v0.13.3` ... which satisfies dependency `ecdsa = "^0.13"` of package `ring-compat v0.4.0` ... which satisfies dependency `ring-compat = "^0.4"` of package `ed25519 v1.4.0-pre (**/ed25519)` versions that meet the requirements `>=1.3.1, <1.5` are: 1.4.0, 1.3.2, 1.3.1To separate or not to separateall possible versions conflict with previously selected packages.
previously selected package
signature v1.5.0
... which satisfies dependency
signature = "^1.5"
(locked to 1.5.0) of packageecdsa v0.13.4 (**/ecdsa)
failed to select a version for
signature
which could resolve this conflict