Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix workspace doc build #1681

Merged
merged 2 commits into from
Sep 30, 2024
Merged

CI: fix workspace doc build #1681

merged 2 commits into from
Sep 30, 2024

Conversation

tarcieri
Copy link
Member

The crypto crate is linking old versions of the trait crates, and that's causing collisions when building the workspace rustdoc:

https://github.com/RustCrypto/traits/actions/runs/11112631698/job/30875140095

warning: output filename collision.
The lib target `aead` in package `aead v0.6.0-rc.0 (/Users/tony/src/RustCrypto/traits/aead)` has the same output filename as the lib target `aead` in package `aead v0.5.2`.
Colliding filename is: /Users/tony/src/RustCrypto/traits/target/doc/aead/index.html
The targets should have unique names.
This is a known bug where multiple crates with the same name use
the same path; see <https://github.com/rust-lang/cargo/issues/6313>.
warning: output filename collision.
The lib target `cipher` in package `cipher v0.5.0-pre.7 (/Users/tony/src/RustCrypto/traits/cipher)` has the same output filename as the lib target `cipher` in package `cipher v0.4.4`.
Colliding filename is: /Users/tony/src/RustCrypto/traits/target/doc/cipher/index.html
The targets should have unique names.
This is a known bug where multiple crates with the same name use
the same path; see <https://github.com/rust-lang/cargo/issues/6313>.

This changes the CI config to exclude it from the rustdoc build for now, since everything else is on a prerelease series.

We should probably bump crypto to link the latest prereleases soon, but for now this gets CI green again.

The `crypto` crate is linking old versions of the trait crates, and
that's causing collisions when building the workspace rustdoc:

    warning: output filename collision.
    The lib target `aead` in package `aead v0.6.0-rc.0 (/Users/tony/src/RustCrypto/traits/aead)` has the same output filename as the lib target `aead` in package `aead v0.5.2`.
    Colliding filename is: /Users/tony/src/RustCrypto/traits/target/doc/aead/index.html
    The targets should have unique names.
    This is a known bug where multiple crates with the same name use
    the same path; see <rust-lang/cargo#6313>.
    warning: output filename collision.
    The lib target `cipher` in package `cipher v0.5.0-pre.7 (/Users/tony/src/RustCrypto/traits/cipher)` has the same output filename as the lib target `cipher` in package `cipher v0.4.4`.
    Colliding filename is: /Users/tony/src/RustCrypto/traits/target/doc/cipher/index.html
    The targets should have unique names.
    This is a known bug where multiple crates with the same name use
    the same path; see <rust-lang/cargo#6313>.

This changes the CI config to exclude it from the rustdoc build for now,
since everything else is on a prerelease series.

We should probably bump `crypto` to link the latest prereleases soon,
but for now this gets CI green again.
@tarcieri tarcieri merged commit 7bc0952 into master Sep 30, 2024
3 checks passed
@tarcieri tarcieri deleted the ci/fix-doc-build branch September 30, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant