Merge pull request #42 from Ryu0118/deprecate-pullbackable

Deprecate Pullbackable
Ryu0118 · Oct 4, 2023 · 510934f · 510934f
2 parents b6a4099 + 08506ef
commit 510934f
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 77 deletions.
diff --git a/README.md b/README.md
@@ -232,7 +232,7 @@ struct ChildView: View, ActionSendable {
 }
 
 struct ChildReducer: ReducerProtocol {
-    enum Action: Pullbackable {
+    enum Action {
         case onButtonTapped
     }
 

diff --git a/Sources/SimplexArchitecture/ActionSendable.swift b/Sources/SimplexArchitecture/ActionSendable.swift
@@ -69,7 +69,7 @@ public extension ActionSendable {
     }
 }
 
-public extension ActionSendable where Reducer.Action: Pullbackable {
+public extension ActionSendable {
     /// Pullbacks the `Action` to the specified case path in the parent's reducer.
     ///
     /// - Parameters:

diff --git a/Sources/SimplexArchitecture/Reducer/Pullbackable.swift b/Sources/SimplexArchitecture/Reducer/Pullbackable.swift
diff --git a/Sources/SimplexArchitecture/Store/Store+send.swift b/Sources/SimplexArchitecture/Store/Store+send.swift
@@ -49,27 +49,14 @@ extension Store {
         defer {
             switch action.kind {
             case .viewAction(let action):
-                guard let pullbackAction else {
-                    break
-                }
-                if let _ = Reducer.Action.self as? Pullbackable.Type {
-                    pullbackAction(action)
-                } else {
-                    runtimeWarning("\(Reducer.Action.self) must be conformed to Pullbackable in order to pullback to parent reducer")
-                }
+                guard let pullbackAction else { break }
+                pullbackAction(action)
             case .reducerAction(let action):
-                guard let pullbackReducerAction else {
-                    break
-                }
-                if let _ = Reducer.ReducerAction.self as? Pullbackable.Type {
-                    pullbackReducerAction(action)
-                } else {
-                    runtimeWarning("\(Reducer.ReducerAction.self) must be conformed to Pullbackable in order to pullback to parent reducer")
-                }
+                guard let pullbackReducerAction else { break }
+                pullbackReducerAction(action)
             }
         }
 
-
         let sideEffect: SideEffect<Reducer>
         // If Unit Testing is in progress and an action is sent from SideEffect
         #if DEBUG

diff --git a/Tests/SimplexArchitectureTests/StoreTests.swift b/Tests/SimplexArchitectureTests/StoreTests.swift
@@ -222,12 +222,12 @@ private struct ParentReducer: ReducerProtocol {
 }
 
 private struct TestReducer: ReducerProtocol {
-    enum ReducerAction: Equatable, Pullbackable {
+    enum ReducerAction: Equatable {
         case c3
         case c4
     }
 
-    enum Action: Equatable, Pullbackable {
+    enum Action: Equatable {
         case c1
         case c2
     }