Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HMR #608

Merged
merged 1 commit into from
May 24, 2024
Merged

Fix HMR #608

merged 1 commit into from
May 24, 2024

Conversation

jwthomson
Copy link
Contributor

Why was HMR broken?

Example sequence of events:

  1. Change made to e.g. Index.fs
  2. Fable and Vite notice a change to the file...
    • Vite doesn't know how to hot reload a .fs file, so it does a full refresh, just in case.
    • Fable does a recompile
  3. Vite sees the new .js files from Fable recompile and does a HMR

Fix

Instruct Vite not to watch .fs files.

@jwthomson jwthomson merged commit dbe6b1c into master May 24, 2024
1 check passed
@jwthomson jwthomson deleted the fix-hmr branch May 24, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattgallagher92 mattgallagher92 mattgallagher92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwthomson @mattgallagher92