Run project tests as part of template testing #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Larocceau
commented
Jul 12, 2024
Larocceau
commented
- Add build action in default project to run tests one-off using mocha test runner (instead of in browser)
- Add build action in template build script to run these tests
mattgallagher92
requested changes
Jul 12, 2024
There was a problem hiding this comment.
Maybe to make the distinction clearer, we should call these targets "RunTestsHeadless" and "WatchRunTests"?
If we rename "RunTests" we should also update docs, so I'm happy for that to be split into a separate issue/PR rather than done now.
There was a problem hiding this comment.
did the rename for runTestsHeadless, let's do the other change next week in conjunction with a docs update
There was a problem hiding this comment.
Thanks! Could you raise an issue to make sure that we remember to do that?
There was a problem hiding this comment.
Let's make sure to update the docs too 👍🏼
Co-authored-by: Matt Gallagher <[email protected]>
Co-authored-by: Matt Gallagher <[email protected]>
Larocceau
force-pushed
the
run-project-tests-as-part-of-template-testing
branch
from
31e1f34 to
60a9a97
Compare
|
All feedback dealt with |
mattgallagher92
approved these changes
Jul 19, 2024
mattgallagher92
requested changes
Jul 19, 2024
mattgallagher92
approved these changes
Jul 19, 2024
|
My last comment is wrong - the README had already been updated. |
mattgallagher92
deleted the
run-project-tests-as-part-of-template-testing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.