New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the api to return full TODO list after adding todo #624

Merged

Larocceau merged 1 commit into master from return-full-todo-list

Aug 16, 2024

Contributor

Larocceau commented Aug 9, 2024 •

edited

Loading

Addresses #615 in a more conclusive manner:

Test failed because it lacked loading the initial data; because the added todo was mapped into a RemoteData type, data disappeared quietly when that RemoteData object was not in the Finished state yet.
Solution: Make the API return the full todo list, so you can fully replace the todo list after an update


          Change the api to return full TODO list after adding todo instead of …

0c4071a

…mixing local and remote state

jwthomson approved these changes

View reviewed changes

Larocceau merged commit dc30e03 into master

1 check passed

Larocceau deleted the return-full-todo-list branch

August 16, 2024 08:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet