Skip to content

Commit

Permalink
Fix typo in SPNameQualifier error text. See #715
Browse files Browse the repository at this point in the history
  • Loading branch information
pitbulk committed Sep 30, 2024
1 parent f4cd947 commit 7f887b4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/onelogin/ruby-saml/response.rb
Original file line number Diff line number Diff line change
Expand Up @@ -833,7 +833,7 @@ def validate_name_id

unless settings.sp_entity_id.nil? || settings.sp_entity_id.empty? || name_id_spnamequalifier.nil? || name_id_spnamequalifier.empty?
if name_id_spnamequalifier != settings.sp_entity_id
return append_error("The SPNameQualifier value mistmatch the SP entityID value.")
return append_error("SPNameQualifier value does not match the SP entityID value.")
end
end
end
Expand Down
2 changes: 1 addition & 1 deletion test/response_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1027,7 +1027,7 @@ def generate_audience_error(expected, actual)
settings.sp_entity_id = 'sp_entity_id'
response_wrong_spnamequalifier.settings = settings
assert !response_wrong_spnamequalifier.send(:validate_name_id)
assert_includes response_wrong_spnamequalifier.errors, "The SPNameQualifier value mistmatch the SP entityID value."
assert_includes response_wrong_spnamequalifier.errors, "SPNameQualifier value does not match the SP entityID value."
end

it "return true when no nameid element but not required by settings" do
Expand Down

0 comments on commit 7f887b4

Please sign in to comment.