Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] add version monitoring parameters to cap-operator-manager #85

Merged
merged 3 commits into from
Sep 27, 2024
Merged

[FEAT] add version monitoring parameters to cap-operator-manager #85

merged 3 commits into from
Sep 27, 2024

Conversation

skrishnan-sap
Copy link
Contributor

@skrishnan-sap skrishnan-sap commented Sep 26, 2024 •
edited
Loading

FIXES (issues in 0.9.0):

  • missing manager permission for captenantoutputs
  • status mismatch for used version of component-operator-runtime

ADDS:

  • version monitoring configuration for controller

CHANGES:

  • enhancements to CAPOperator CRD
    • added controller.versionMonitoring to configure Prometheus integration
    • added volumes and volumeMounts to controller and subscriptionServer
  • regenerated manifest (for deployment)
  • enhanced transformation logic
  • added unit tests

TESTING:

  • candidate: ghcr.io/skrishnan-sap/cap-operator-lifecycle/cap-operator-manager:sha-d7baa57

@skrishnan-sap skrishnan-sap marked this pull request as ready for review September 27, 2024 07:44
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@skrishnan-sap skrishnan-sap mentioned this pull request Sep 27, 2024
Closed
anirudhprasad-sap
anirudhprasad-sap approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@anirudhprasad-sap anirudhprasad-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skrishnan-sap skrishnan-sap merged commit 7466a68 into main Sep 27, 2024
7 checks passed
@skrishnan-sap skrishnan-sap deleted the manager-with-vers-mon branch September 27, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anirudhprasad-sap anirudhprasad-sap anirudhprasad-sap approved these changes

@Pavan-SAP Pavan-SAP Awaiting requested review from Pavan-SAP

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skrishnan-sap @anirudhprasad-sap