Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implicit structural nodes #1002

Merged
merged 25 commits into from
Dec 19, 2019
Merged

Implicit structural nodes #1002

merged 25 commits into from
Dec 19, 2019

Conversation

maxmarkus
Copy link
Contributor

Replace the environments node extended/navigation.js:51

{
      hideFromNav: true,
      pathSegment: 'environments/:environmentId',
      viewUrl: '/sampleapp.html#/environments/:environmentId'
},

@maxmarkus maxmarkus added the enhancement New feature or request label Dec 3, 2019
@maxmarkus maxmarkus marked this pull request as ready for review December 3, 2019 15:10
@maxmarkus maxmarkus added the WIP Work in progress label Dec 3, 2019
@JohannesDoberer JohannesDoberer added this to the Sprint 8 milestone Dec 4, 2019
@zarkosimic zarkosimic self-assigned this Dec 4, 2019
@alexandra-simeonova alexandra-simeonova self-assigned this Dec 5, 2019
@pekura pekura self-assigned this Dec 5, 2019
@maxmarkus maxmarkus removed the WIP Work in progress label Dec 6, 2019
alexandra-simeonova
alexandra-simeonova reviewed Dec 9, 2019
View reviewed changes
docs/navigation-configuration.md Outdated Show resolved Hide resolved
docs/navigation-configuration.md Outdated Show resolved Hide resolved
pekura
pekura suggested changes Dec 11, 2019
View reviewed changes
core/src/navigation/services/navigation.js Outdated Show resolved Hide resolved
core/src/utilities/helpers/generic-helpers.js Outdated Show resolved Hide resolved
@JohannesDoberer JohannesDoberer merged commit 8781f0e into SAP:master Dec 19, 2019
@JohannesDoberer JohannesDoberer deleted the 924-implicit-nodes branch December 19, 2019 13:21
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@maxmarkus @JohannesDoberer
Implicit structural nodes (SAP#1002)
7e4e9f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pekura pekura pekura approved these changes

@zarkosimic zarkosimic zarkosimic approved these changes

@alexandra-simeonova alexandra-simeonova alexandra-simeonova approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@kazydek kazydek Awaiting requested review from kazydek

@marynaKhromova marynaKhromova Awaiting requested review from marynaKhromova

@bszwarc bszwarc Awaiting requested review from bszwarc

@majakurcius majakurcius Awaiting requested review from majakurcius

Assignees

@pekura pekura

@zarkosimic zarkosimic

@alexandra-simeonova alexandra-simeonova

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 8
Development

Successfully merging this pull request may close these issues.
5 participants
@maxmarkus @pekura @zarkosimic @alexandra-simeonova @JohannesDoberer