Add valid href to navigation links #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxmarkus
requested review from
alexandra-simeonova,
bszwarc,
hardl,
JohannesDoberer,
kazydek,
majakurcius,
marynaKhromova,
pekura and
zarkosimic
as code owners
…maxmarkus/luigi into 1032-add-valid-href-to-navigation-links
|
I seem to be getting a weird behaviour with the ContextSwitcher. The href shows as 'undefined' for Environment 1,2,3 until 9. They work fine if opened in the same tab but not in new ones. |
…maxmarkus/luigi into 1032-add-valid-href-to-navigation-links
ndricimrr
approved these changes
Jan 16, 2020
…maxmarkus/luigi into 1032-add-valid-href-to-navigation-links
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Feb 12, 2020
* master: Debug cypress travis issue (SAP#1097) Fix communication from external mf using customMessages (SAP#1081) fix fd-modal mix-up (SAP#1068) who is using luigi in about page (SAP#1077) Add cobrick logo (SAP#1072) who is using luigi button (SAP#1066) Update README.md Update README.md release v0.7.4 (SAP#1069) fix items calculation in more btn of tab nav(SAP#1065) Add valid href to navigation links (SAP#1034) fix runtime error when contextSwitcher is not defined (SAP#1047) Improve API documentation (SAP#1025) Improve authorization doc structure (SAP#1024) Improve Overview page (SAP#1000) Improve application-setup.md (SAP#965) create content guidelines (#877) Documentation fixes (SAP#1003) # Conflicts: # docs/luigi-core-api.md # test/e2e.sh
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added configurable option to show href links in the navigation.