Dynamic pathSegments in navigation Nodes #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… viewUrl, added some documentation and example implementation, overview link
maxmarkus
requested review from
antiheld and
dariadomagala-sap
as code owners
maxmarkus
requested review from
kazydek,
klaudiagrz,
kwiatekus,
pekura,
tomekpapiernik and
y-kkamil
as code owners
maxmarkus
changed the title
kazydek
reviewed
Sep 25, 2018
docs/lifecycle.md
Outdated
| - **getEventData()** returns the context object. Usually it is not required as the **addContextUpdateListener** receives the same values. | ||
| - **getPathParams()** returns the dynamic path parameters of the active url. |
docs/navigation-configuration.md
Outdated
| @@ -64,7 +65,7 @@ window.Luigi.setConfig({ | |||
|
|
|||
| ## Nodes | |||
|
|
|||
| - **pathSegment** specifies the partial URL of the current segment. A static settings example reflects `luigidomain.test/settings`, while a dynamic one loads on any other value. | |||
| - **pathSegment** specifies the partial URL of the current segment. A static settings example reflects `luigidomain.test/settings`, while a dynamic, prefixed with colon, loads on any other value. **pathSegments** must not contain slashes. | |||
maxmarkus
changed the title
…to feature/dynamic-nodes
kazydek
approved these changes
Sep 26, 2018
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* initial dynamic node implementation. substitution for pathSegment and viewUrl, added some documentation and example implementation, overview link * removed obsolete routes and component, added child node to dynamic node example * added context substitution and enhanced config and example * added test for findMatchingNode * small fix for undefined param * removed # from tets, added navigation tets for findMatchingNode * documentation updates * refactored handling of falsy dynamic nodes, updated tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added possibility to add dynamic nodes. pathSegments prefixed with colon (:) will be substituted in pathSegment, viewUrl and context and are available as LuigiClient.getPathParams().
Related issue(s)
Resolves #94