Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands path info in angular example readme #107

Conversation

parostatkiem-zz
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Added info about commands path to luigi-sample-angular readme

Related issue(s)
Resolves #106

@parostatkiem-zz parostatkiem-zz added bug Something isn't working area/luigi labels Sep 25, 2018
@parostatkiem-zz parostatkiem-zz added this to the Sprint_Framefrog_1 milestone Sep 25, 2018
@parostatkiem-zz parostatkiem-zz requested a review from a user September 25, 2018 11:58
@CLAassistant
Copy link

CLAassistant commented Sep 25, 2018

CLA assistant check
All committers have signed the CLA.

```bash
# The `lerna bootstrap` command executes the Node Package Manager (NPM) installation and links cross-dependencies.

lerna bootstrap
```

3. Bundle the Luigi core.
3. Bundle the Luigi core by executing the following in `luigi/core` folder.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bundle the Luigi core by executing the following in the luigi/core folder.

```bash
# Lerna runs the bundle script in every package where the script exists.

lerna run bundle
```

4. Start the example application.
4. Start the example application from `luigi/core/examples/luigi-sample-angular` folder.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start the example application from the luigi/core/examples/luigi-sample-angular folder.

@parostatkiem-zz parostatkiem-zz force-pushed the commands-path-info-in-angular-example-readme branch from cb7a126 to 846e5ed Compare September 25, 2018 12:41
@parostatkiem-zz parostatkiem-zz merged commit 981e91d into SAP:master Sep 25, 2018
@parostatkiem-zz parostatkiem-zz deleted the commands-path-info-in-angular-example-readme branch September 26, 2018 13:30
@lszymik lszymik removed this from the Sprint_Framefrog_1 milestone Sep 27, 2018
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
* Provide path info to installation/launch commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants