Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add splitview functionality #1076

Merged
merged 27 commits into from
Feb 26, 2020

Conversation

ndricimrr
Copy link
Contributor

@ndricimrr ndricimrr commented Jan 31, 2020

Description

Changes proposed in this pull request:

  • The function openAsSplitview is implemented.
  • In addition the navigate function does support splitview as well.

Status Update:
Ready for review

Related issue(s)

@zarkosimic zarkosimic added this to the Sprint 9 milestone Feb 5, 2020
@JohannesDoberer JohannesDoberer self-assigned this Feb 5, 2020
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small things

core/src/core-api/splitViewHandle.js Outdated Show resolved Hide resolved
core/src/main.js Outdated Show resolved Hide resolved
@maxmarkus maxmarkus self-assigned this Feb 10, 2020
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job 👍

Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Good refactoring.

core/src/core-api/navigation.js Outdated Show resolved Hide resolved
core/src/core-api/navigation.js Outdated Show resolved Hide resolved
core/src/core-api/navigation.js Outdated Show resolved Hide resolved
core/src/core-api/navigation.js Outdated Show resolved Hide resolved
@alexandra-simeonova alexandra-simeonova self-assigned this Feb 12, 2020
@maxmarkus maxmarkus added documentation documentation tasks enhancement New feature or request labels Feb 19, 2020
@JohannesDoberer JohannesDoberer merged commit 60b3d59 into SAP:master Feb 26, 2020
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Feb 28, 2020
…f github.com:JohannesDoberer/luigi into 1094-Refactor-resolved-node-children-data-management

* '1094-Refactor-resolved-node-children-data-management' of github.com:JohannesDoberer/luigi:
  Add splitview functionality (SAP#1076)
@ndricimrr ndricimrr deleted the add-splitview-functionality branch September 8, 2020 13:59
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation tasks enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants