Open profile items in a modal window #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarkosimic
requested review from
hardl,
JohannesDoberer,
marynaKhromova,
maxmarkus and
pekura
as code owners
core/src/Authorization.html
Outdated
| typeof item.openNodeInModal === 'object' && | ||
| item.openNodeInModal !== null | ||
| ) { | ||
| const route = RoutingHelpers.buildRoute(item, `/${item.link}`); |
There was a problem hiding this comment.
route is in my case //settings. I would remove the slash.
marynaKhromova
approved these changes
Feb 6, 2020
marynaKhromova
approved these changes
Feb 7, 2020
JohannesDoberer
approved these changes
Feb 10, 2020
zarkosimic
deleted the
1078_profile_items_should_be_able_to_open_in_modal_window
branch
JohannesDoberer
added a commit
that referenced
this pull request
Feb 17, 2020
* master: remove tech writers and add alex to default users (#1104) update sample app (#1106) Update README.md release-v0.7.5 (#1102) Svelte example app (#1070) update fiddle (#1100) Open profile items in a modal window (#1083) # Conflicts: # .travis.yml # test/e2e-test-application/package-lock.json # test/e2e-test-application/package.json
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Go to
core/examples/luigi-sample-angular/src/luigi-config/extended/navigation.jsfind settings node and replace with this one{ pathSegment: 'settings', hideFromNav: true, hideSideNav: true, label: 'Settings', viewUrl: '/sampleapp.html#/settings' }.In the same file, find getProfileItems and in items array add this node
{ label: "Settings", icon: "action-settings", link: "/settings", openNodeInModal: { title: "Settings M", size: "m" } }.Before changes:
After changes: