Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile icon tooltip text #1115

Merged
merged 12 commits into from
Mar 5, 2020

Conversation

maxmarkus
Copy link
Contributor

Adds a name or email (fallback) to profile icon as title.

@maxmarkus maxmarkus added the enhancement New feature or request label Feb 24, 2020
@maxmarkus maxmarkus added this to the Sprint 9 milestone Feb 24, 2020
@JohannesDoberer JohannesDoberer self-assigned this Feb 27, 2020
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndricimrr ndricimrr self-assigned this Mar 2, 2020
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxmarkus maxmarkus merged commit 63f96dd into SAP:master Mar 5, 2020
@maxmarkus maxmarkus deleted the 1110-profile-icon-tooltip-text branch March 5, 2020 13:19
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Mar 18, 2020
* master: (26 commits)
  Add implementations/scenarios (SAP#1116)
  deleteCache was missing in contextswitcher (SAP#1148)
  Update type descriptions (SAP#1131)
  Route change loses context in contextswitcher (SAP#1145)
  Debug cypress travis - parallel e2e tests (SAP#1121)
  trying to run npm step only if triggered or pushed to master (SAP#1139)
  Release v0.7.6 revert docs fiddle (SAP#1138)
  travis fix
  travis fix
  travis fix
  Release v0.7.6 fix (SAP#1137)
  Release v0.7.6 (SAP#1136)
  Refactor resolved node children data management (SAP#1119)
  Ability to update core URL without mf url change (SAP#1111)
  Add documentation search (SAP#1123)
  OIDC profile interceptor (SAP#1129)
  Added userInfo title to profile item (SAP#1115)
  Update documentation for examples + consolidate filenames (SAP#1099)
  Document how to make use of contextUpdateListener (SAP#1109)
  Document how to set auth storage type (SAP#1096)
  ...

# Conflicts:
#	.travis.yml
#	client/luigi-client.d.ts
#	client/package-lock.json
#	client/package.json
#	client/public/package.json
#	core/examples/luigi-sample-angular/src/assets/sampleexternal.html
#	core/package-lock.json
#	core/package.json
#	core/public/package.json
#	core/src/core-api/_internalLinkManager.js
#	core/src/core-api/baseClass.js
#	core/src/main.js
#	core/src/navigation/TopNav.html
#	docs/application-setup.md
#	docs/getting-started.md
#	docs/luigi-client-api.md
#	lerna.json
#	plugins/auth/src/auth-oidc/index.js
#	scripts/setup/angular.sh
#	scripts/setup/no-framework.sh
#	scripts/setup/openui5.sh
#	scripts/setup/vue.sh
#	test/e2e-test-application/e2e/tests/navigation.spec.js
#	test/e2e-test-application/package.json
#	test/e2e-test-application/src/app/project/dynamic/dynamic.component.ts
#	test/e2e-test-application/src/luigi-config/extended/auth.js
#	website/fiddle/package.json
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants