-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add customSelectedOptionRenderer to style ContextSwitcher dropdown button #1151
Merged
JohannesDoberer
merged 34 commits into
SAP:release-v1
from
ndricimrr:1134-custom-rendering-selected-context-switcher
Mar 26, 2020
Merged
Add customSelectedOptionRenderer to style ContextSwitcher dropdown button #1151
JohannesDoberer
merged 34 commits into
SAP:release-v1
from
ndricimrr:1134-custom-rendering-selected-context-switcher
Mar 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Aleksandra Simeonova <[email protected]>
alexandra-simeonova
approved these changes
Mar 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 👍
maxmarkus
suggested changes
Mar 12, 2020
Co-Authored-By: Markus <[email protected]>
Co-Authored-By: Markus <[email protected]>
JohannesDoberer
approved these changes
Mar 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
maxmarkus
approved these changes
Mar 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…endering-selected-context-switcher
maxmarkus
reviewed
Mar 20, 2020
prettier, beautiful :) Co-Authored-By: Markus <[email protected]>
…endering-selected-context-switcher
JohannesDoberer
approved these changes
Mar 23, 2020
…ted-context-switcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Added function to customise context switcher button label
In order to test it append the following entry to contextSwitcher.options at test/e2e-test-application/src/luigi-config/extended/navigation.js:233 after label and pathValue
customRendererCategory: n !== 1 ? n % 2 == 0 ? "production" : "stage" : “”
Next add another entry to the
contextSwitcher{...}
Result:
![cswitcher](https://user-images.githubusercontent.com/18335489/77070841-44292680-69eb-11ea-9ce1-5bf662e33c8a.gif)
Add this flag to lerna when bootstrapping if your dependencies are not linked:
lerna bootstrap --force-local
Related issue(s)