Fix fonts bundling in luigi core #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parostatkiem-zz
requested review from
antiheld,
dariadomagala-sap,
hardl,
jesusreal,
kwiatekus,
maxmarkus,
pekura and
y-kkamil
as code owners
parostatkiem-zz
requested review from
kazydek,
klaudiagrz and
tomekpapiernik
as code owners
jesusreal
suggested changes
Oct 2, 2018
docs/application-setup.md
Outdated
| @@ -70,7 +70,7 @@ $ mv src/index.html src/angular.html | |||
| $ curl https://raw.githubusercontent.com/kyma-project/Luigi/master/core/examples/luigi-sample-angular/src/index.html > src/index.html | |||
| $ curl https://raw.githubusercontent.com/kyma-project/Luigi/master/core/examples/luigi-sample-angular/src/assets/basicConfiguration.js > src/assets/sampleconfig.js | |||
| $ sed 's/"src\/index.html"/"src\/angular.html"/g' angular.json > tmp.json && mv tmp.json angular.json | |||
| $ sed 's/"src\/assets"/"src\/assets","src\/index.html", {"glob": "fundamental-ui.min.css", "input": "node_modules\/fundamental-ui\/dist","output": "\/fundamental-ui"}, {"glob": "fonts\/**","input": "node_modules\/fundamental-ui\/dist","output": "\/fundamental-ui"}, {"glob": "SAP-icons.*","input": "node_modules\/fundamental-ui\/dist","output": "\/fundamental-ui"}, {"glob": "**","input": "node_modules\/@kyma-project\/luigi-core", "output": "\/luigi-core"},{"glob": "**","input": "node_modules\/@kyma-project\/luigi-client","output": "\/luigi-client"}/g' angular.json > tmp.json && mv tmp.json angular.json | |||
| $ sed 's/"src\/assets"/"src\/assets","src\/index.html", {"glob": "**","input": "node_modules\/@kyma-project\/luigi-core", "output": "\/luigi-core"},{"glob": "**","input": "node_modules\/@kyma-project\/luigi-client","output": "\/luigi-clien t"}/g' angular.json > tmp.json && mv tmp.json angular.json | |||
There was a problem hiding this comment.
Looks that there is a typo, should be luigi-client instead of luigi-clien t
jesusreal
approved these changes
Oct 2, 2018
klaudiagrz
approved these changes
Oct 3, 2018
…ix-fonts-bundling-in-Luigi-core # Conflicts: # core/examples/luigi-sample-angular/package-lock.json # core/package.json
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* Remove all fundamental-ui imports in example app * Solve problem & change non-working fallback css loader * Update documentation according to changes in angular.json file * Fix typo & add font file to .gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fundamental UI icons now work independently from client app.
Changes proposed in this pull request:
cssfile providing previously bugged @font-face rule. It's not affected by Svelte.style-loaderinwebpack.config.jstofile-loader(which works!).Resolves #88