Navigation node as a link to an external page #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parostatkiem-zz
requested review from
antiheld,
dariadomagala-sap,
hardl,
jesusreal,
kazydek,
klaudiagrz,
kwiatekus,
maxmarkus,
pekura,
tomekpapiernik and
y-kkamil
as code owners
klaudiagrz
reviewed
Oct 2, 2018
docs/navigation-configuration.md
Outdated
| @@ -66,6 +66,8 @@ window.Luigi.setConfig({ | |||
| ## Nodes | |||
|
|
|||
| - **pathSegment** specifies the partial URL of the current segment. A static settings example reflects `luigidomain.test/settings`, while a dynamic one, prefixed with a colon, loads on any other value. **pathSegments** must not contain slashes. | |||
| - **externalLinkUrl** specifies the external URL that Node leads to. If this property is set, **pathSegment** will be ignored. | |||
There was a problem hiding this comment.
If this property is set, **pathSegment** is ignored.
docs/navigation-configuration.md
Outdated
| @@ -66,6 +66,8 @@ window.Luigi.setConfig({ | |||
| ## Nodes | |||
|
|
|||
| - **pathSegment** specifies the partial URL of the current segment. A static settings example reflects `luigidomain.test/settings`, while a dynamic one, prefixed with a colon, loads on any other value. **pathSegments** must not contain slashes. | |||
| - **externalLinkUrl** specifies the external URL that Node leads to. If this property is set, **pathSegment** will be ignored. | |||
| - **sameWindow** defines if the external URL should be opened in new or current tab. Works only if **externalLinkUrl** is set. | |||
There was a problem hiding this comment.
defines if the external URL is opened in a new or current tab.
klaudiagrz
reviewed
Oct 3, 2018
docs/navigation-configuration.md
Outdated
| - **externalLinkUrl** specifies the external URL that Node leads to. If this property is set, **pathSegment** will be ignored. | ||
| - **sameWindow** defines if the external URL should be opened in new or current tab. Works only if **externalLinkUrl** is set. | ||
| - **externalLinkUrl** specifies the external URL that Node leads to. If this property is set, **pathSegment** is ignored. | ||
| - **sameWindow** defines if the external URL sis opened in a new or current tab. Works only if **externalLinkUrl** is set. |
klaudiagrz
approved these changes
Oct 3, 2018
maxmarkus
reviewed
Oct 4, 2018
…avigation-node-as-a-link-to-external-page # Conflicts: # core/src/LeftNav.html # core/src/TopNav.html
parostatkiem-zz
force-pushed
the
Navigation-node-as-a-link-to-external-page
branch
from
0a0093b to
f3bc754
Compare
klaudiagrz
suggested changes
Oct 8, 2018
docs/navigation-configuration.md
Outdated
| - **context** sends the specified object as context to the view. Use this parameter in combination with the dynamic **pathSegment** to receive the context through the context listeners of **Luigi client**. This is an alternative to using the dynamic value in the **viewUrl**. | ||
| - **defaultChildNode** sets the child node that Luigi activates automatically if the current node has no **viewUrl** defined. Provide **pathSegment** of the child node you want to activate as a string. | ||
| - **isolateView** renders the view in a new frame when you enter and leave the Node. This setting overrides the same-domain frame re-usage. The **isolateView** is disabled by default. | ||
| - **externalLink** is an object specifying that the node should link to an external URL. If this property is set, **pathSegment** is ignored. It consists of the following properties: |
There was a problem hiding this comment.
**externalLink** is an object which specifies that the Node links to an external URL.
docs/navigation-configuration.md
Outdated
| - **isolateView** renders the view in a new frame when you enter and leave the Node. This setting overrides the same-domain frame re-usage. The **isolateView** is disabled by default. | ||
| - **externalLink** is an object specifying that the node should link to an external URL. If this property is set, **pathSegment** is ignored. It consists of the following properties: | ||
| - **sameWindow** defines if the external URL is opened in a new or current tab. | ||
| - **url** the external URL that Node leads to. |
There was a problem hiding this comment.
**url** is the external URL that the Node leads to.
docs/navigation-configuration.md
Outdated
|
|
||
| * **label** contains the display name of the navigation Node. | ||
| * **hideFromNav** shows or hides a navigation Node. You can still navigate to the Node but it will not show up in the top or left pane. | ||
| * **viewUrl** contains the URL or path to a view that renders when entering the navigation Node. Use either a full URL or a relative path. This value may consist of variables if you have specified a **navigationContext** with a dynamic **pathSegment**. If **viewUrl** is undefined, Luigi activates the child node specified in **defaultChildNode**. When both **viewUrl** and **defaultChildNode** are undefined, Luigi opens the first child of the current node. |
There was a problem hiding this comment.
- ...renders
when you enter the navigation Node. - ...
Luigi activates the child Node specified... -> capitalize Node the current Node
docs/navigation-configuration.md
Outdated
| * **hideFromNav** shows or hides a navigation Node. You can still navigate to the Node but it will not show up in the top or left pane. | ||
| * **viewUrl** contains the URL or path to a view that renders when entering the navigation Node. Use either a full URL or a relative path. This value may consist of variables if you have specified a **navigationContext** with a dynamic **pathSegment**. If **viewUrl** is undefined, Luigi activates the child node specified in **defaultChildNode**. When both **viewUrl** and **defaultChildNode** are undefined, Luigi opens the first child of the current node. | ||
| * **navigationContext** contains a named Node that is mainly for use in combination with a dynamic **pathSegment** to start navigation from a dynamic Node using `LuigiClient.navigationManager().fromContext('contextname')`. | ||
| * **context** sends the specified object as context to the view. Use this parameter in combination with the dynamic **pathSegment** to receive the context through the context listeners of **Luigi client**. This is an alternative to using the dynamic value in the **viewUrl**. |
There was a problem hiding this comment.
This is an alternative to using the dynamic value in the **viewUrl**.
klaudiagrz
approved these changes
Oct 8, 2018
# Conflicts: # core/examples/luigi-sample-angular/src/app/overview/overview.component.ts # core/src/LeftNav.html # core/src/services/navigation.js # docs/navigation-configuration.md
maxmarkus
suggested changes
Oct 11, 2018
| @@ -31,6 +31,11 @@ export class OverviewComponent { | |||
| link: '/projects/pr1/users/groups', | |||
| text: 'dynamic Nodes', | |||
| description: 'navigation Node configuration to set a specific node as dynamic' | |||
| }, | |||
| { | |||
| link: 'http://google.com', | |||
There was a problem hiding this comment.
Please do not link to an external page here. Maybe lets move the external Link from top navigation into the projects where we have also 'Default Child Node Example' and '(Isolated View)', so the features are grouped together. And link to /projects/pr1.
There was a problem hiding this comment.
I'd leave the external link in the top navigation to show the developer he can also put it there.
There was a problem hiding this comment.
What do you think @maxmarkus ?
|
The external link should have dedicated style class so that user can distinguish them. This doesnt work yet |
…om:parostatkiem/luigi into Navigation-node-as-a-link-to-external-page
…s-a-link-to-external-page # Conflicts: # core/src/LeftNav.html # core/src/TopNav.html
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* Implement externalLink nodes * Correct readme * Correct the typo * Add external links icon * Improve route click handling * Change externalLink to object * Update readme * Change overview and place of example externalUrl nodes * fixed external link icons * reverted backdrop changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
externalLinkURLproperty defined,pathSegmentproperty is ignored along with the whole routing mechanizm/#/ext)Resolves #91