Translate tooltip text in semi collapsed mode and add title attributes to entries in left nav #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
zarkosimic
requested review from
hardl,
JohannesDoberer,
marynaKhromova,
maxmarkus and
pekura
as code owners
maxmarkus
reviewed
Apr 22, 2020
maxmarkus
approved these changes
Apr 22, 2020
JohannesDoberer
approved these changes
Apr 23, 2020
…github.com:zarkosimic/luigi into 1276_tooltip_in_semi-collapsed_mode_not_translated # Conflicts: # core/src/navigation/TabNav.html
zarkosimic
deleted the
1276_tooltip_in_semi-collapsed_mode_not_translated
branch
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Apr 27, 2020
* master: updated luigi version in fiddle and docs website (SAP#1298) Refactor Svelte example app (SAP#1270) Release v1.1.0 (SAP#1297) update fundamental styles library version in angular example 0.8.1 (SAP#1245) Fix semicollapsible issue (SAP#1292) Translate tooltip text in semi collapsed mode and add title attributes to entries in left nav (SAP#1283) Oidc provider uses storage type also for oidc client configuration (SAP#1269)
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
…s to entries in left nav (SAP#1283)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1276
Fixes #1277
Changes proposed in this pull request: