Make automatic login configurable #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariadomagala-sap
requested review from
antiheld,
hardl,
jesusreal,
kwiatekus,
maxmarkus,
pekura and
y-kkamil
as code owners
dariadomagala-sap
requested review from
bszwarc,
kazydek,
klaudiagrz and
tomekpapiernik
as code owners
maxmarkus
suggested changes
Oct 10, 2018
maxmarkus
approved these changes
Oct 10, 2018
| if (!getConfigValue('auth.disableAutoLogin')) { | ||
| this.startAuthorization(); | ||
| return; | ||
| }; |
There was a problem hiding this comment.
Would try to avoid the evaluation negation here, as it is not necessary.
if (getConfigValue('auth.disableAutoLogin')) {
return;
};
this.startAuthorization();
return
Hint: if the config value would be truthy, we could do something like that:
return getConfigValue('auth.autoLogin') && this.startAuthorization();
kazydek
reviewed
Oct 10, 2018
docs/authorization-configuration.md
Outdated
| @@ -1,13 +1,14 @@ | |||
| # Authorization Configuration | |||
|
|
|||
| Luigi provides OpenID Connect and OAuth2 Implicit Grant authorization out of the box. The **use** key defines the active authorization provider. | |||
| Luigi provides OpenID Connect and OAuth2 Implicit Grant authorization out of the box. The **use** key defines the active authorization provider and the **disableAutoLogin** key allows to disable the automatic login flow that is provided by default. | |||
kazydek
approved these changes
Oct 10, 2018
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* Add the possibility to disable auto-login
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)