Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple persistent development setup #1317

Merged
merged 6 commits into from
May 7, 2020
Merged

Simple persistent development setup #1317

merged 6 commits into from
May 7, 2020

Conversation

hardl
Copy link
Contributor

@hardl hardl commented May 6, 2020

  • also changed webpack afterEmit hook to support windows
  • removed scroll-bounce on new ms edge

@hardl hardl added the enhancement New feature or request label May 6, 2020
@hardl hardl added this to the Sprint 10 milestone May 6, 2020
@hardl hardl requested review from maxmarkus and JohannesDoberer May 6, 2020 15:14
@JohannesDoberer JohannesDoberer self-assigned this May 6, 2020
@maxmarkus maxmarkus self-assigned this May 7, 2020
maxmarkus
maxmarkus suggested changes May 7, 2020
View reviewed changes
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, just some changes required.

core/dev-tools/simpledev.js Outdated Show resolved Hide resolved
core/dev-tools/templates/simple/index.html Outdated Show resolved Hide resolved
core/dev-tools/templates/simple/luigi-config.js Outdated Show resolved Hide resolved
core/dev-tools/templates/simple/microfrontend.html Outdated Show resolved Hide resolved
maxmarkus
maxmarkus approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxmarkus maxmarkus changed the title simple persistent development setup Simple persistent development setup May 7, 2020
@JohannesDoberer JohannesDoberer merged commit c8ea8d4 into SAP:master May 7, 2020
@maxmarkus maxmarkus mentioned this pull request May 7, 2020
Merged
@hardl hardl deleted the simple_dev branch May 7, 2020 18:05
JohannesDoberer added a commit that referenced this pull request May 8, 2020
@JohannesDoberer
Merge branch 'master' into feature-globalsearch
a0ae1df 
* master:
  added product and context switch to visibility check of three dot menu (#1321)
  Luigi update to v1.1.1 (#1319)
  fix tabnav active state indication (#1318)
  Simple persistent development setup (#1317)
  Link to 0.7.x documentation (#1287)
  Cache improvements for dynamic nodes (#1278)
  update luigi version in docs and adjust layout (#1301)
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@hardl
Simple persistent development setup (SAP#1317)
8503a45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxmarkus maxmarkus maxmarkus approved these changes

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@marynaKhromova marynaKhromova Awaiting requested review from marynaKhromova

@pekura pekura Awaiting requested review from pekura

@zarkosimic zarkosimic Awaiting requested review from zarkosimic

Assignees

@maxmarkus maxmarkus

@JohannesDoberer JohannesDoberer

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 10
Development

Successfully merging this pull request may close these issues.
3 participants
@hardl @maxmarkus @JohannesDoberer