Improve basic configuration and documentation #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxmarkus
requested review from
antiheld,
bszwarc,
dariadomagala-sap,
hardl,
jesusreal,
kazydek,
klaudiagrz,
kwiatekus,
pekura,
tomekpapiernik and
y-kkamil
as code owners
pekura
reviewed
Oct 11, 2018
| <h1 class="fd-action-bar__title"> | ||
| Basic Example page | ||
| </h1> | ||
| <p class="fd-action-bar__description">This page behaves equally to an external hosted micro front-end.</p> |
There was a problem hiding this comment.
I do not get what is the intent of saying this. Maybe it would be interesting to say that this example behaves like a single page app.
There was a problem hiding this comment.
How about: This micro front-end behaves like a single page application.
pekura
approved these changes
Oct 12, 2018
bszwarc
suggested changes
Oct 15, 2018
| @@ -30,13 +30,22 @@ To have this application running, follow these steps: | |||
| ``` | |||
|
|
|||
| 4. Start the example application from the `luigi/core/examples/luigi-sample-angular` folder. | |||
|
|
|||
| `/assets/sampleConfiguration.js` is the default configuration with a showcase of all available features. If you want to try out the much simpler example, change the configuration reference in `index.html` to `basicConfiguration.js`. | |||
There was a problem hiding this comment.
try out the much simpler > try out a much simpler
| npm run start | ||
| ``` | ||
|
|
||
| To run Luigi with path based routing, change the **routing.useHashrouting** configuration to `false` and run the following command: |
There was a problem hiding this comment.
Maybe we can have it as an unordered list:
- To run Luigi with hash based routing ...
- To run Luigi with path based routing ...
It would make the instructions clearer.
…us/luigi into improve-basic-configuration-docu
…asic-configuration-docu
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* improved documentation and basic configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
#134