Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semicollapsible resize #1431

Merged
merged 19 commits into from
Jul 1, 2020

Conversation

maxmarkus
Copy link
Contributor

Adds a check if persisted collapsible state is closed and prevent persistion on resize.

Fixes #1422

@maxmarkus maxmarkus added the bug Something isn't working label Jun 23, 2020
@maxmarkus maxmarkus added this to the Sprint 11 milestone Jun 23, 2020
@zarkosimic zarkosimic self-assigned this Jun 23, 2020
@ndricimrr ndricimrr self-assigned this Jun 23, 2020
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resizing is pretty smooth 👍
Somehow though, if I start/refresh the page with browser previously sized to min width and try to expand the window, it doesn't seem to obey 🤔

@maxmarkus maxmarkus merged commit 3732078 into SAP:master Jul 1, 2020
@maxmarkus maxmarkus deleted the 1422-fix-semicollapsible-resize branch July 1, 2020 13:37
@maxmarkus maxmarkus mentioned this pull request Jul 2, 2020
JohannesDoberer added a commit that referenced this pull request Jul 6, 2020
* master: (21 commits)
  style the mobile avigation for Documentation (#1452)
  allow hash and section deeplinks (#1447)
  Add link to blogs (#1442)
  Release v1.2.4 (#1457)
  Fix logout label (#1453)
  adds a check if persisted collapsible state is closed and prevent persistion on resize (#1431)
  update links (#1445)
  1381 update version of Fundamental Styles on Fiddle to 0.10.0 (#1414)
  1381 update version of Fundamental Styles on Fiddle to 0.10.0 (#1414)
  1381 update version of Fundamental Styles on Fiddle to 0.10.0 (#1414)
  1381 update version of Fundamental Styles on Fiddle to 0.10.0 (#1414)
  redirect for blog on landingpage
  Add blog to website (#1439)
  release v1.2.3 (#1437)
  remove non-working code (#1436)
  Release v1.2.2 (#1435)
  fix double frame (#1433)
  Added showLabel attribute to node for top level nav (#1429)
  Strip Documentation in Changelog generation (#1404)
  Feature/badge counter (#1409)
  ...
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Jul 6, 2020
* feature-globalsearch: (21 commits)
  style the mobile avigation for Documentation (SAP#1452)
  allow hash and section deeplinks (SAP#1447)
  Add link to blogs (SAP#1442)
  Release v1.2.4 (SAP#1457)
  Fix logout label (SAP#1453)
  adds a check if persisted collapsible state is closed and prevent persistion on resize (SAP#1431)
  update links (SAP#1445)
  1381 update version of Fundamental Styles on Fiddle to 0.10.0 (SAP#1414)
  1381 update version of Fundamental Styles on Fiddle to 0.10.0 (SAP#1414)
  1381 update version of Fundamental Styles on Fiddle to 0.10.0 (SAP#1414)
  1381 update version of Fundamental Styles on Fiddle to 0.10.0 (SAP#1414)
  redirect for blog on landingpage
  Add blog to website (SAP#1439)
  release v1.2.3 (SAP#1437)
  remove non-working code (SAP#1436)
  Release v1.2.2 (SAP#1435)
  fix double frame (SAP#1433)
  Added showLabel attribute to node for top level nav (SAP#1429)
  Strip Documentation in Changelog generation (SAP#1404)
  Feature/badge counter (SAP#1409)
  ...
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong semiCollapsible side navigation behavior on resize
4 participants