Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe get path params and get node params better #155

Merged

Conversation

pekura
Copy link
Contributor

@pekura pekura commented Oct 23, 2018

  • describe get path params and get node params in Luigi Client doc better
  • fix broken links to Luigi Client doc in the main readme

@maxmarkus maxmarkus self-assigned this Oct 24, 2018
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment

client/luigi-client.js Show resolved Hide resolved
Copy link
Contributor

@parostatkiem-zz parostatkiem-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No big deal but I was honest as a person who has never seen these things

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bszwarc bszwarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments.

client/luigi-client.js Show resolved Hide resolved
docs/luigi-client-api.md Outdated Show resolved Hide resolved
docs/luigi-client-api.md Outdated Show resolved Hide resolved
docs/luigi-client-api.md Outdated Show resolved Hide resolved
docs/luigi-client-api.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bszwarc bszwarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added my comments - I think something went wrong when resolving the merging conflict, and we have the same document twice.

docs/README.md Show resolved Hide resolved
docs/luigi-client-api.md Outdated Show resolved Hide resolved
docs/luigi-client-api.md Outdated Show resolved Hide resolved
docs/luigi-client-api.md Outdated Show resolved Hide resolved
docs/luigi-client-api.md Outdated Show resolved Hide resolved
docs/luigi-client-api.md Outdated Show resolved Hide resolved
docs/luigi-client-api.md Outdated Show resolved Hide resolved
docs/luigi-client-api.md Outdated Show resolved Hide resolved
docs/luigi-client-api.md Outdated Show resolved Hide resolved
docs/luigi-client-api.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bszwarc bszwarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three minor comments.

docs/luigi-client-api.md Show resolved Hide resolved
docs/luigi-client-api.md Show resolved Hide resolved
docs/luigi-client-api.md Show resolved Hide resolved
Copy link
Contributor

@bszwarc bszwarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, the remaining changes will be done as part of another task.

docs/luigi-client-api.md Show resolved Hide resolved
docs/luigi-client-api.md Show resolved Hide resolved
docs/luigi-client-api.md Show resolved Hide resolved
@kwiatekus kwiatekus merged commit fa29af0 into SAP:master Nov 7, 2018
jesusreal pushed a commit to maxmarkus/luigi that referenced this pull request Nov 7, 2018
Improve documentation around path parameters and node parameters
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Improve documentation around path parameters and node parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants