-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe get path params and get node params better #155
Describe get path params and get node params better #155
Conversation
pekura
commented
Oct 23, 2018
- describe get path params and get node params in Luigi Client doc better
- fix broken links to Luigi Client doc in the main readme
This reverts commit ec5f47c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No big deal but I was honest as a person who has never seen these things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments.
…etter # Conflicts: # README.md # client/luigi-client.js # docs/README.md # docs/luigi-client-api.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added my comments - I think something went wrong when resolving the merging conflict, and we have the same document twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, the remaining changes will be done as part of another task.
Improve documentation around path parameters and node parameters
Improve documentation around path parameters and node parameters