Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature toggles #1571

Merged
merged 36 commits into from
Aug 25, 2020
Merged

Feature toggles #1571

merged 36 commits into from
Aug 25, 2020

Conversation

JohannesDoberer
Copy link
Contributor

No description provided.

@JohannesDoberer
feature toggle core api
5f25bdd
@JohannesDoberer
Merge branch 'master' into featureToggle
4fc2e9e 
* master:
  wc async loading issue (SAP#1554)
  Switching from CLA to DCO (SAP#1538)
  Update OpenUI5 Example (SAP#1541)
  Markdown plugin dev improvement (SAP#1519)
@JohannesDoberer
no message
e59a090
@JohannesDoberer
no message
1a26cd2
@JohannesDoberer
featureToggle
94a7dab
@JohannesDoberer
no message
910c9da
@JohannesDoberer
Merge branch 'master' into featureToggle
b7c1586 
* master:
  Bump serialize-javascript in /core/examples/luigi-example-vue (SAP#1558)
  Bump serialize-javascript from 2.1.1 to 3.1.0 in /core (SAP#1548)
  Bump serialize-javascript from 2.1.1 to 3.1.0 in /website/docs (SAP#1556)
  Bump serialize-javascript from 2.1.1 to 3.1.0 in /client (SAP#1547)
  Bump serialize-javascript in /core/examples/luigi-example-angular (SAP#1557)
@JohannesDoberer
no message
b25b6e7
@JohannesDoberer
Merge branch 'master' into featureToggle
741e7ae 
* master:
  Release v1.3.1 (SAP#1566)
  Docu: Improve readability of function names (SAP#1559)
  Link to blog feed (SAP#1563)
  Remove generated website assets (SAP#1550)
  add reuse badge to readme (SAP#1555)
@JohannesDoberer
no message
862a5c0
@JohannesDoberer
no message
42e42ff
@JohannesDoberer
hash routing support
d965107
@JohannesDoberer
docu and tests
2e71a2d
@JohannesDoberer
Merge branch 'master' into featureToggle
a40bb3f 
* master:
  update fiddle to 1.3.1 (SAP#1567)

# Conflicts:
#	website/fiddle/package-lock.json
@JohannesDoberer JohannesDoberer added the enhancement New feature or request label Aug 17, 2020
@JohannesDoberer JohannesDoberer added this to the Sprint 12 milestone Aug 17, 2020
@JohannesDoberer JohannesDoberer added the documentation documentation tasks label Aug 17, 2020
@alexandra-simeonova alexandra-simeonova self-assigned this Aug 18, 2020
@ndricimrr ndricimrr self-assigned this Aug 18, 2020
alexandra-simeonova
alexandra-simeonova reviewed Aug 18, 2020
View reviewed changes
docs/advanced-scenarios.md Show resolved Hide resolved
docs/advanced-scenarios.md Outdated Show resolved Hide resolved
docs/advanced-scenarios.md Outdated Show resolved Hide resolved
docs/navigation-parameters-reference.md Outdated Show resolved Hide resolved
JohannesDoberer and others added 3 commits August 18, 2020 20:16
@JohannesDoberer @alexandra-simeonova
Update docs/navigation-parameters-reference.md
7decab8 
Co-authored-by: Aleksandra Simeonova <[email protected]>
@JohannesDoberer
typescript definition
7826623
@JohannesDoberer
Merge branch 'featureToggle' of github.com:JohannesDoberer/luigi into…
d4c5029 
… featureToggle

* 'featureToggle' of github.com:JohannesDoberer/luigi:
  Update docs/navigation-parameters-reference.md
UlianaMunich
UlianaMunich approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@UlianaMunich UlianaMunich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job!

alexandra-simeonova
alexandra-simeonova approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@alexandra-simeonova alexandra-simeonova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ndricimrr
ndricimrr approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

stanleychh
stanleychh reviewed Aug 21, 2020
View reviewed changes
core/src/App.html Outdated Show resolved Hide resolved
@stanleychh stanleychh self-assigned this Aug 21, 2020
maxmarkus
maxmarkus suggested changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@maxmarkus maxmarkus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job, just some remarks.

core/test/utilities/helpers/routing-helpers.spec.js Outdated Show resolved Hide resolved
core/src/core-api/featuretoggles.js Outdated Show resolved Hide resolved
core/src/core-api/featuretoggles.js Outdated Show resolved Hide resolved
core/src/core-api/featuretoggles.js Outdated Show resolved Hide resolved
core/src/core-api/featuretoggles.js Outdated Show resolved Hide resolved
test/e2e-test-application/src/app/project/settings/settings.component.html Outdated Show resolved Hide resolved
website/docs/src/luigi-config/extended/routing.js Outdated Show resolved Hide resolved
core/src/core-api/featuretoggles.js Outdated Show resolved Hide resolved
@maxmarkus maxmarkus self-assigned this Aug 24, 2020
maxmarkus
maxmarkus approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JohannesDoberer
no message
09cae8b
@JohannesDoberer
Merge branch 'master' into featureToggle
27caaea 
* master:
  Docu: Examples for client lifecycle api (SAP#1561)
  Content security policy clean (SAP#1565)

# Conflicts:
#	client/src/lifecycleManager.js
#	docs/luigi-client-api.md
@JohannesDoberer
no message
3be4be5
@JohannesDoberer
typo
e2d56ba
@JohannesDoberer
docu improvement
47455ba
@JohannesDoberer JohannesDoberer merged commit 5135bb4 into SAP:master Aug 25, 2020
@JohannesDoberer JohannesDoberer deleted the featureToggle branch August 25, 2020 17:19
@ndricimrr ndricimrr mentioned this pull request Sep 9, 2020
Merged
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@JohannesDoberer
Feature toggles (SAP#1571)
5fc74e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanleychh stanleychh stanleychh left review comments

@maxmarkus maxmarkus maxmarkus approved these changes

@UlianaMunich UlianaMunich UlianaMunich approved these changes

@ndricimrr ndricimrr ndricimrr approved these changes

@alexandra-simeonova alexandra-simeonova alexandra-simeonova approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

Assignees

@maxmarkus maxmarkus

@UlianaMunich UlianaMunich

@stanleychh stanleychh

@ndricimrr ndricimrr

@alexandra-simeonova alexandra-simeonova

Labels
documentation documentation tasks enhancement New feature or request
Projects
None yet
Milestone
Sprint 12
Development

Successfully merging this pull request may close these issues.
6 participants
@JohannesDoberer @maxmarkus @UlianaMunich @stanleychh @ndricimrr @alexandra-simeonova