Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shellbar buttons alignment issue #1606

Merged
merged 8 commits into from
Sep 8, 2020
Merged

Fix shellbar buttons alignment issue #1606

merged 8 commits into from
Sep 8, 2020

Conversation

stanleychh
Copy link
Contributor

Fixes #1604

shellbar-button

@stanleychh stanleychh added the bug Something isn't working label Sep 3, 2020
@stanleychh stanleychh added this to the Sprint 13 milestone Sep 3, 2020
@UlianaMunich UlianaMunich self-assigned this Sep 3, 2020
@ndricimrr ndricimrr self-assigned this Sep 4, 2020
@UlianaMunich UlianaMunich removed their assignment Sep 4, 2020
ndricimrr
ndricimrr reviewed Sep 4, 2020
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as @UlianaMunich , couldn't manage to reproduce it in my machine 🤔

@JohannesDoberer JohannesDoberer self-assigned this Sep 7, 2020
@stanleychh
Copy link
Contributor Author

@hardl, thanks for your time investigating this issue. I have pushed a fix of removing line height.

@hardl
Copy link
Contributor

hardl commented Sep 7, 2020

turns out that this issue is caused by

.fd-shellbar__button .fd-top-nav__icon {
line-height: 2.4rem;
...

which is also responsible for additional misalignment.

Please revert
margin-top: 10px;

and remove line-height

JohannesDoberer
JohannesDoberer approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hardl hardl added the priority/critical Priority indication label Sep 8, 2020
ndricimrr
ndricimrr approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stanleychh stanleychh merged commit ebeb41d into SAP:master Sep 8, 2020
@ndricimrr ndricimrr mentioned this pull request Sep 9, 2020
Merged
stanleychh added a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@stanleychh
Fix shellbar buttons alignment issue (SAP#1606)
31de624 
* Remove line height
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@ndricimrr ndricimrr ndricimrr approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@UlianaMunich UlianaMunich Awaiting requested review from UlianaMunich

Assignees

@JohannesDoberer JohannesDoberer

@ndricimrr ndricimrr

Labels
bug Something isn't working priority/critical Priority indication
Projects
None yet
Milestone
Sprint 13
Development

Successfully merging this pull request may close these issues.

Shellbar buttons are not aligned
5 participants
@stanleychh @hardl @JohannesDoberer @ndricimrr @UlianaMunich