feature/expose-login-method

[ionutcirja]

Description

Changes proposed in this pull request:

• expose login method

[CLAassistant]

All committers have signed the CLA.

[alexandra-simeonova]

Thank you for your contribution! 🚀
A friendly tip: because API documentation is different from other documentation in Luigi (it is automatically generated), we'd like to ask you to run lerna run docu from the root Luigi folder. (If you didn't install Lerna yet, look here.) This should then generate the documentation.

[ionutcirja]

Hello guys, do you have any idea how soon can you merge this? Thanks.

[maxmarkus]

Hello @ionutcirja

I have checked your PR and it is working. Since I would like to see the the stuff tested, I have created the e2e test for you.
Would you please add it to fiddle-navigation.spec.js:338 after the No profile, logged intest?

      it('Trigger Login and Logout with Core API', () => {
        newConfig.navigation.profile = undefined;
        newConfig.auth.disableAutoLogin = true;
        visitWithAuthConfig('/', newConfig);

        cy.get('[data-testid="luigi-topnav-profile"] button').click();
        loginLink().should('exist');

        cy.window().then(win => {
          cy.log('Trigger auth().login()');
          win.Luigi.auth().login();
        });

        cy.login('[email protected]', 'tets', true);

        cy.get('[data-testid="luigi-topnav-profile"] button').click();
        logoutLink().should('exist');

        cy.window().then(win => {
          cy.log('Trigger auth().logout()');
          win.Luigi.auth().logout();
        });

        cy.contains('Login again');
      });

FYI: To let this test run locally, run website/fiddle: npm start and test/e2e-test-application: npm run e2e:open and click on the fiddle-navigation.spec.js.

We will try to merge it today, then you would be able to use the nightly (-dev) build tomorrow.

[maxmarkus]

LGTM. Thanks! 👍

[maxmarkus]

Thank you for your contribution! 🚀
A friendly tip: because API documentation is different from other documentation in Luigi (it is automatically generated), we'd like to ask you to run lerna run docu from the root Luigi folder. (If you didn't install Lerna yet, look here.) This should then generate the documentation.

I guess a missing npm install in the root folder is the root-cause, it would install the pre-commit and pre-push hooks that do the job. @ionutcirja be sure to run npm install in the main repo folder to be safe for the future.