Change Search using Luigi.globalSearch() API (#1690) #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change Search using Luigi.globalSearch() API * Adding Tag clickable + search using Luigi Message * Adding @legteodav in CODEOWNERS * Cleaning a bit more the code (console, whitespace) * Fixing overlay problem Removing white spaces Fixing highlight html for some key search terms Removing search.js * Removing useless files Improving code quality (white spaces, type errors, etc etc) * More Cleaning code * fixing css problems * Integrating code review changes * Fix Css problem for Mobile application * Fix Css problem for Arrow (it was not rotating...)
legteodav
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
maxmarkus,
ndricimrr,
stanleychh and
UlianaMunich
as code owners
Implementing arrayDown, arrowUp and Enter on search result
* Fixing result url to be relative Implementing arrayDown, arrowUp and Enter on search result * Adding back algolia logo
hardl
approved these changes
Dec 1, 2020
UlianaMunich
reviewed
Dec 1, 2020
Comment on lines
+556
to
+558
| /*&.lui-simpleSlideInNav .fd-app__sidebar { | ||
| left: -$side-nav-width-mobile; | ||
| } | ||
| }*/ |
UlianaMunich
approved these changes
Dec 1, 2020
JohannesDoberer
added a commit
that referenced
this pull request
Dec 2, 2020
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Dec 2, 2020
Merged
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* Change Search using Luigi.globalSearch() API (SAP#1690) * Change Search using Luigi.globalSearch() API * Adding Tag clickable + search using Luigi Message * Adding @legteodav in CODEOWNERS * Cleaning a bit more the code (console, whitespace) * Fixing overlay problem Removing white spaces Fixing highlight html for some key search terms Removing search.js * Removing useless files Improving code quality (white spaces, type errors, etc etc) * More Cleaning code * fixing css problems * Integrating code review changes * Fix Css problem for Mobile application * Fix Css problem for Arrow (it was not rotating...) * Fixing result url to be relative (SAP#1736) Implementing arrayDown, arrowUp and Enter on search result * DOC Search: add back Algolia Logo in results (SAP#1737) * Fixing result url to be relative Implementing arrayDown, arrowUp and Enter on search result * Adding back algolia logo * Remove dotted line from left side nav deep link click (SAP#1739) * Update index.scss * fixing border for mobile application in search result (SAP#1745) Co-authored-by: Philipp Pracht <[email protected]> Co-authored-by: Uliana Caceres <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Search using Luigi.globalSearch() API
Adding Tag clickable + search using Luigi Message
Adding @legteodav in CODEOWNERS
Cleaning a bit more the code (console, whitespace)
Fixing overlay problem
Removing white spaces
Fixing highlight html for some key search terms
Removing search.js
Removing useless files
Improving code quality (white spaces, type errors, etc etc)
More Cleaning code
fixing css problems
Integrating code review changes
Fix Css problem for Mobile application
Fix Css problem for Arrow (it was not rotating...)
Description
Changes proposed in this pull request:
Related issue(s)