Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global search enhancements #1738 #1753

Merged
merged 26 commits into from
Dec 15, 2020
Merged

Global search enhancements #1738 #1753

merged 26 commits into from
Dec 15, 2020

Conversation

legteodav
Copy link
Contributor

@legteodav legteodav commented Dec 2, 2020 •
edited by ndricimrr
Loading

Global search enhancements
Fixes #1738

@legteodav legteodav linked an issue Dec 2, 2020 that may be closed by this pull request
global search enhancements #1738
Closed
@JohannesDoberer JohannesDoberer added this to the Sprint 14 milestone Dec 3, 2020
@JohannesDoberer JohannesDoberer added the enhancement New feature or request label Dec 3, 2020
@JohannesDoberer JohannesDoberer self-assigned this Dec 4, 2020
@UlianaMunich UlianaMunich self-assigned this Dec 4, 2020
UlianaMunich
UlianaMunich suggested changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@UlianaMunich UlianaMunich left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works great! Just a suggestion from my side, since "Placeholder" is a one word, I'd suggest to write it that way, without capitalized "H". I mean, instead of PlaceHolder, having Placeholder instead. See my suggestions below.

core/src/core-api/globalsearch.js Outdated Show resolved Hide resolved
core/src/App.html Outdated Show resolved Hide resolved
docs/navigation-parameters-reference.md Outdated Show resolved Hide resolved
test/e2e-test-application/src/luigi-config/extended/globalSearch.js Outdated Show resolved Hide resolved
test/e2e-test-application/src/luigi-config/extended/globalSearch.js Outdated Show resolved Hide resolved
@alexandra-simeonova alexandra-simeonova self-assigned this Dec 7, 2020
alexandra-simeonova
alexandra-simeonova reviewed Dec 7, 2020
View reviewed changes
docs/navigation-parameters-reference.md Outdated Show resolved Hide resolved
docs/navigation-parameters-reference.md Outdated Show resolved Hide resolved
docs/navigation-parameters-reference.md Outdated Show resolved Hide resolved
@stanleychh stanleychh self-assigned this Dec 7, 2020
@JohannesDoberer JohannesDoberer removed their assignment Dec 8, 2020
stanleychh
stanleychh reviewed Dec 8, 2020
View reviewed changes
core/src/navigation/GlobalSearch.html Outdated Show resolved Hide resolved
core/src/navigation/GlobalSearch.html Outdated Show resolved Hide resolved
stanleychh
stanleychh reviewed Dec 8, 2020
View reviewed changes
core/src/App.html Outdated Show resolved Hide resolved
@JohannesDoberer JohannesDoberer mentioned this pull request Dec 11, 2020
Closed
@legteodav legteodav merged commit a0091bc into SAP:master Dec 15, 2020
JohannesDoberer added a commit to alexandra-simeonova/luigi that referenced this pull request Dec 15, 2020
@JohannesDoberer
Merge branch 'web-components-docu' of github.com:alexandra-simeonova/…
b74b758 
…luigi into web-components-docu

* 'web-components-docu' of github.com:alexandra-simeonova/luigi:
  Global search enhancements SAP#1738 (SAP#1753)
  Bump ini from 1.3.5 to 1.3.8 in /scripts (SAP#1783)
  Bump ini from 1.3.5 to 1.3.8 in /website/docs (SAP#1780)
  Bump ini from 1.3.5 to 1.3.7 in /client (SAP#1774)
  Bump ini from 1.3.5 to 1.3.7 in /core (SAP#1775)
  replace insensitive term (SAP#1771)
@JohannesDoberer JohannesDoberer mentioned this pull request Dec 23, 2020
Merged
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Jan 7, 2021
@JohannesDoberer
Merge branch 'master' into custom-mf-for-user-settings
09827b1 
* master:
  Release v1.7.1 (SAP#1793)
  Update example on luigi-core-api.md navigate() (SAP#1769)
  Reversed search for keepselected (SAP#1761)
  fiddle patch
  Browser history fix  (SAP#1784)
  Manage user settings (SAP#1789)
  Fix drawer undefined bug (SAP#1765)
  Fixing cypress tests for Angular Test Application (SAP#1730)
  Global search enhancements SAP#1738 (SAP#1753)

# Conflicts:
#	client/webpack.config.js
#	core/package.json
#	core/src/App.html
#	core/src/UserSettingsDialog.html
#	core/src/UserSettingsEditor.html
#	core/src/core-api/config.js
#	core/src/core-api/ux.js
#	core/src/utilities/constants.js
#	core/src/utilities/helpers/usersetting-dialog-helpers.js
#	docs/luigi-core-api.md
#	test/e2e-test-application/src/luigi-config/extended/projectDetailNav.js
#	test/e2e-test-application/src/luigi-config/extended/settings.js
stanleychh added a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@legteodav @JohannesDoberer
@UlianaMunich @alexandra-simeonova @stanleychh
Global search enhancements SAP#1738 (SAP#1753)
8798154 
* Adding placeholder for globasearch: string, function or localizible

* Adding Toggle Search function

* Update core/src/core-api/globalsearch.js

Co-authored-by: Uliana Caceres <[email protected]>

* Update docs/navigation-parameters-reference.md

Co-authored-by: Uliana Caceres <[email protected]>

* Update test/e2e-test-application/src/luigi-config/extended/globalSearch.js

Co-authored-by: Uliana Caceres <[email protected]>

* Update test/e2e-test-application/src/luigi-config/extended/globalSearch.js

Co-authored-by: Uliana Caceres <[email protected]>

* Update core/src/App.html

Co-authored-by: Uliana Caceres <[email protected]>

* fixing some typos in test comments

* Update test/e2e-test-application/src/luigi-config/extended/globalSearch.js

Co-authored-by: Uliana Caceres <[email protected]>

* Update docs/navigation-parameters-reference.md

Co-authored-by: Aleksandra Simeonova <[email protected]>

* Update docs/navigation-parameters-reference.md

Co-authored-by: Aleksandra Simeonova <[email protected]>

* Update docs/navigation-parameters-reference.md

Co-authored-by: Aleksandra Simeonova <[email protected]>

* Changing PlaceHolder to Placeholder... and Retesting everything

* Update core/src/navigation/GlobalSearch.html

Co-authored-by: Stanley Hsu <[email protected]>

* reducing number of search.searchProvider occurencies

* changing let to const....

* changing let to const....

* changing toggleSearch method

* fixing cypress tests...

* refactor if to get in one ust line

* removing variable declaration ...

* Using Translation in Placeholder

* Removing alert on toggleSearch

Co-authored-by: JohannesDoberer <[email protected]>
Co-authored-by: Uliana Caceres <[email protected]>
Co-authored-by: Aleksandra Simeonova <[email protected]>
Co-authored-by: Stanley Hsu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandra-simeonova alexandra-simeonova alexandra-simeonova left review comments

@UlianaMunich UlianaMunich UlianaMunich approved these changes

@stanleychh stanleychh stanleychh approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

Assignees

@UlianaMunich UlianaMunich

@stanleychh stanleychh

@alexandra-simeonova alexandra-simeonova

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 14
Development

Successfully merging this pull request may close these issues.

global search enhancements
5 participants
@legteodav @UlianaMunich @stanleychh @alexandra-simeonova @JohannesDoberer