Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Core fundamental styles from v.11 to v.14 #1805

Merged
merged 33 commits into from
Jan 29, 2021

Conversation

UlianaMunich
Copy link
Contributor

@UlianaMunich UlianaMunich commented Jan 11, 2021

Fixes #1643

Main overall changes:

  • all icons were moved to a separate tag and necessary classes .sap-icon*
  • left-side navigation was broken because of padding/margin
  • were removed media queries for mobile/desktop shellbar, so I added it only for Luigi Core t make it all work
  • fixed some :focus states in Shellbar

legteodav
legteodav previously approved these changes Jan 11, 2021
Copy link
Contributor

@legteodav legteodav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was testing Fiddle and e2e application (with my Chrome) and everything looks good...

Copy link
Contributor

@legteodav legteodav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just let me know when tests are fixed...

@legteodav legteodav dismissed their stale review January 11, 2021 15:48

Waiting tests fixes

@JohannesDoberer JohannesDoberer added this to the Sprint 15 milestone Jan 12, 2021
@JohannesDoberer JohannesDoberer self-assigned this Jan 15, 2021
@JohannesDoberer JohannesDoberer modified the milestones: Sprint 15, Sprint 16 Jan 21, 2021
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good job!

@JohannesDoberer JohannesDoberer merged commit d2bb850 into SAP:master Jan 29, 2021
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Feb 2, 2021
* master:
  travis slack integration update
  Update FD Styles to v.14 in E2E App (SAP#1817)
  Update Core fundamental styles from v.11 to v.14 (SAP#1805)
  Update fiddle version to 1.8.1 (SAP#1843)
  Move user settings config to an own section (SAP#1833)
  merging with master (SAP#1744)
  Release v1.8.1 (SAP#1851)
  fixed id_token only oidc flow (SAP#1840)
  Removing spinner background (SAP#1849)
  Wrong release tag for nightly in ng support lib  SAP#1844 (SAP#1847)
  Fixing publishing problem (SAP#1844)
  Fixing CheckMark issue (SAP#1822)
  fix query param subscriptions issue (SAP#1839)

# Conflicts:
#	core/src/UserSettingsDialog.html
#	core/src/UserSettingsEditor.html
#	test/e2e-test-application/src/luigi-config/extended/settings.js
@JohannesDoberer JohannesDoberer added the breaking Breaking change label Feb 5, 2021
@JohannesDoberer JohannesDoberer mentioned this pull request Feb 5, 2021
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update FD Styles >= 0.13.0 (CORE package)
3 participants