-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if meta data are configured #1861
Merged
JohannesDoberer
merged 13 commits into
SAP:master
from
JohannesDoberer:bug-fix-custom-mf-on-usersettings
Feb 11, 2021
Merged
Check if meta data are configured #1861
JohannesDoberer
merged 13 commits into
SAP:master
from
JohannesDoberer:bug-fix-custom-mf-on-usersettings
Feb 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esDoberer/luigi into bug-fix-custom-mf-on-usersettings * 'bug-fix-custom-mf-on-usersettings' of github.com:JohannesDoberer/luigi: Add documentation about breaking changes in Luigi 1.9.0 due to FD Sty… (SAP#1857)
legteodav
reviewed
Feb 9, 2021
legteodav
reviewed
Feb 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added a very minor code suggestion (just to improve a bit readability)
legteodav
approved these changes
Feb 9, 2021
stanleychh
approved these changes
Feb 9, 2021
stanleychh
approved these changes
Feb 9, 2021
…troduce margin for editor content
* master: bugfix custom read/write function in usersettings config (SAP#1883) Different visual appearances for boolean#1768 (SAP#1854) Support semantic types for confirmation modal (SAP#1863) # Conflicts: # core/src/UserSettingsEditor.html # test/e2e-test-application/src/luigi-config/extended/userSettings.js
Merged
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Feb 12, 2021
* master: Update .travis.yml delay for custom mf in user setttings dialog test change latest tag different order of tag list change back to default user settings Release v1.10 (SAP#1885) Error handling for user settings dialog (SAP#1861) bugfix custom read/write function in usersettings config (SAP#1883) Different visual appearances for boolean#1768 (SAP#1854) Support semantic types for confirmation modal (SAP#1863) # Conflicts: # core/src/UserSettingsDialog.html # core/src/UserSettingsEditor.html
JohannesDoberer
added a commit
that referenced
this pull request
Feb 25, 2021
* master: Blog post with Luigi updates (#1880) Fix error in navigation docs 1824 Silent Renew for OIDC documentation theming.nodeViewURLDecorator should also be applied to settings micro frontends viewUrl General/User settings docu review Update App.svelte Update feed version to 4.2.2 1835 Update fiddle with new version of fs-extra-9.0.1.tgz (#1875) Update .travis.yml delay for custom mf in user setttings dialog test change latest tag different order of tag list change back to default user settings Release v1.10 (#1885) Error handling for user settings dialog (#1861) bugfix custom read/write function in usersettings config (#1883) Different visual appearances for boolean#1768 (#1854) Support semantic types for confirmation modal (#1863) # Conflicts: # core/src/UserSettingsDialog.html # core/src/UserSettingsEditor.html
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check if meta data are configured