Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if meta data are configured #1861

Merged

Conversation

JohannesDoberer
Copy link
Contributor

check if meta data are configured

@legteodav legteodav self-assigned this Feb 9, 2021
Copy link
Contributor

@legteodav legteodav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added a very minor code suggestion (just to improve a bit readability)

@stanleychh stanleychh self-assigned this Feb 9, 2021
* master:
  bugfix custom read/write function in usersettings config  (SAP#1883)
  Different visual appearances for boolean#1768 (SAP#1854)
  Support semantic types for confirmation modal (SAP#1863)

# Conflicts:
#	core/src/UserSettingsEditor.html
#	test/e2e-test-application/src/luigi-config/extended/userSettings.js
@JohannesDoberer JohannesDoberer merged commit 78c1fc2 into SAP:master Feb 11, 2021
@JohannesDoberer JohannesDoberer deleted the bug-fix-custom-mf-on-usersettings branch February 11, 2021 14:50
@JohannesDoberer JohannesDoberer mentioned this pull request Feb 11, 2021
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Feb 12, 2021
* master:
  Update .travis.yml
  delay for custom mf in user setttings dialog test
  change latest tag
  different order of tag list
  change back to default
  user settings
  Release v1.10 (SAP#1885)
  Error handling for user settings dialog (SAP#1861)
  bugfix custom read/write function in usersettings config  (SAP#1883)
  Different visual appearances for boolean#1768 (SAP#1854)
  Support semantic types for confirmation modal (SAP#1863)

# Conflicts:
#	core/src/UserSettingsDialog.html
#	core/src/UserSettingsEditor.html
JohannesDoberer added a commit that referenced this pull request Feb 25, 2021
* master:
  Blog post with Luigi updates (#1880)
  Fix error in navigation docs
  1824 Silent Renew for OIDC documentation
  theming.nodeViewURLDecorator should also be applied to settings micro frontends viewUrl
  General/User settings docu review
  Update App.svelte
  Update feed version to 4.2.2
  1835 Update fiddle with new version of fs-extra-9.0.1.tgz (#1875)
  Update .travis.yml
  delay for custom mf in user setttings dialog test
  change latest tag
  different order of tag list
  change back to default
  user settings
  Release v1.10 (#1885)
  Error handling for user settings dialog (#1861)
  bugfix custom read/write function in usersettings config  (#1883)
  Different visual appearances for boolean#1768 (#1854)
  Support semantic types for confirmation modal (#1863)

# Conflicts:
#	core/src/UserSettingsDialog.html
#	core/src/UserSettingsEditor.html
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants