Fix for goBack when not using micro-frontend without routing #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxmarkus
requested review from
antiheld,
dariadomagala-sap,
hardl,
jesusreal,
kwiatekus,
parostatkiem-zz,
pekura and
y-kkamil
as code owners
jesusreal
reviewed
Nov 5, 2018
There was a problem hiding this comment.
Tested with angular example using path routing, and navigating from "External Page" (no routing) to "Settings" page and then clicking "go Back" in the settings view. Bug is fixed thanks to the code additions. (Note: I needed to remove # sign in the viewUrl for external page so that Luigi considers there is no hashRouting happening).
jesusreal
suggested changes
Nov 5, 2018
client/luigi-client.js
Outdated
| @@ -109,10 +109,13 @@ | |||
| var hashRoutingModeActive = | |||
There was a problem hiding this comment.
Please move this variable initialisation to the inner scope of the new if block you created.
…nto bugfix/go-back-refresh
jesusreal
approved these changes
Nov 5, 2018
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* skipping navigation when in navigateBack mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip url change in LuigiClient when going back.