Login fix #222
Merged
Login fix #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardl
requested review from
antiheld,
dariadomagala-sap,
jesusreal,
kwiatekus,
maxmarkus,
parostatkiem-zz,
pekura and
y-kkamil
as code owners
jesusreal
suggested changes
Nov 20, 2018
|
|
||
| const isNodeAccessPermitted = ( | ||
| nodeToCheckPermissionFor, | ||
| parentNode, | ||
| currentContext | ||
| ) => { | ||
| if (!isLoggedIn()) return false; |
There was a problem hiding this comment.
I see this already 3 times in our codebase, we could create a helper in LuigiConfig class and reuse it instead of duplicating code. Here my proposal.
There was a problem hiding this comment.
Pushed by myself as requested from pr creator
jesusreal
approved these changes
Nov 20, 2018
kwiatekus
suggested changes
Nov 20, 2018
| @@ -52,10 +52,7 @@ | |||
|
|
|||
| export default { | |||
| oncreate() { | |||
| const idpProviderName = LuigiConfig.getConfigValue('auth.use'); | |||
There was a problem hiding this comment.
Looks like this is needed in the code executed below:
L82: idpProviderInstance = getIdpProviderInstance(idpProviderName, idpProviderSettings);
kwiatekus
approved these changes
Nov 20, 2018
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
fixed problem with node visibility w/o auth enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request: