Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logout.html to webpack config #234

Merged
merged 1 commit into from
Nov 22, 2018
Merged

Add logout.html to webpack config #234

merged 1 commit into from
Nov 22, 2018

Conversation

kwiatekus
Copy link
Contributor

@kwiatekus kwiatekus commented Nov 22, 2018 •
edited
Loading

Description

Changes proposed in this pull request:

  • logout.html is properly bundled for webpack dev server

@kwiatekus kwiatekus added bug Something isn't working area/luigi labels Nov 22, 2018
@kwiatekus kwiatekus added this to the Sprint_Swinka_4 milestone Nov 22, 2018
@kwiatekus kwiatekus mentioned this pull request Nov 22, 2018
Closed
@jesusreal jesusreal self-assigned this Nov 22, 2018
jesusreal
jesusreal approved these changes Nov 22, 2018
View reviewed changes
Copy link
Contributor

@jesusreal jesusreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

maxmarkus
maxmarkus approved these changes Nov 22, 2018
View reviewed changes
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesusreal jesusreal merged commit df25d3e into SAP:master Nov 22, 2018
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@kwiatekus @jesusreal
Add logout.html to webpack config (SAP#234)
ff1cd48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxmarkus maxmarkus maxmarkus approved these changes

@jesusreal jesusreal jesusreal approved these changes

@antiheld antiheld Awaiting requested review from antiheld

@dariadomagala-sap dariadomagala-sap Awaiting requested review from dariadomagala-sap

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@parostatkiem-zz parostatkiem-zz Awaiting requested review from parostatkiem-zz

@pekura pekura Awaiting requested review from pekura

@y-kkamil y-kkamil Awaiting requested review from y-kkamil

Assignees

@jesusreal jesusreal

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kwiatekus @maxmarkus @jesusreal