Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with path routing #235

Merged
merged 6 commits into from
Nov 23, 2018
Merged

Issues with path routing #235

merged 6 commits into from
Nov 23, 2018

Conversation

jesusreal
Copy link
Contributor

@jesusreal jesusreal commented Nov 22, 2018 •
edited
Loading

Description

Changes proposed in this pull request:

  • Context switcher to work properly (path routing)
  • Avoid infinite loop when logging out and logging in again (path routing)
  • Popstate event listener is now executed (path routing)

@jesusreal jesusreal added bug Something isn't working area/luigi labels Nov 22, 2018
@jesusreal jesusreal added this to the Sprint_Swinka_4 milestone Nov 22, 2018
kwiatekus
kwiatekus approved these changes Nov 22, 2018
View reviewed changes
Copy link
Contributor

@kwiatekus kwiatekus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested all the flows that didnt work before.
Tested path and hash routing.
LGTM

@kwiatekus kwiatekus merged commit 8c6fa74 into SAP:master Nov 23, 2018
@jesusreal jesusreal deleted the issues-with-path-routing branch December 21, 2018 08:04
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@jesusreal @kwiatekus
Issues with path routing (SAP#235)
7a7fcb6 
Issues with path routing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwiatekus kwiatekus kwiatekus approved these changes

@pekura pekura pekura approved these changes

@antiheld antiheld Awaiting requested review from antiheld

@dariadomagala-sap dariadomagala-sap Awaiting requested review from dariadomagala-sap

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@parostatkiem-zz parostatkiem-zz Awaiting requested review from parostatkiem-zz

@y-kkamil y-kkamil Awaiting requested review from y-kkamil

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jesusreal @kwiatekus @pekura