Fix the relative path bug

[dariadomagala-sap]

Description

Changes proposed in this pull request:

• Fix the relative path bug

Related issue(s)

[maxmarkus]

LGTM

[pekura]

I think it is safer to align the path by number of path segments. My suggestion would be:

export const buildFromRelativePath = node => {
  let windowPath = LuigiConfig.getConfigValue('routing.useHashRouting')
    ? getPathWithoutHash(window.location.hash)
    : window.location.pathname;
  if (node.parent && node.parent.pathSegment) {
    const nodePathSegments = trimLeadingSlash(getNodePath(node.parent)).split('/');
    const windowPathSegments = trimLeadingSlash(windowPath).split('/');
    if (windowPathSegments.length > nodePathSegments.length) {
      windowPath = windowPathSegments.slice(0, nodePathSegments.length).join('/');
    }
  }
  return addLeadingSlash(concatenatePath(windowPath, node.link));
};

[jesusreal]

A small suggestion here, for consistency and avoiding issues with leading / trailing slashes in the future or between routing strategies, I would use helper methods to normalize nodePathSegments and windowPathSegments before applying split, something like:

const nodePathSegments = Helpers.normalizePath(getNodePath(node.parent)).split('/');
const windowPathSegments = Helpers.normalizePath(windowPath).split('/');

Also what is being checked in if (windowPathSegments.length > nodePathSegments.length - 1) is at least for me not straightforward to understand, maybe a variable with a meaningful name would be helpful.

[pekura]

Yeah, I removed the '-1', it was not necessary with properly prepared paths.

[dariadomagala-sap]

I applied suggested changes :)
The only difference is that instead of
windowPath = windowPathSegments.slice(0, nodePathSegments.length).join('/');
I used
windowPath = nodePathSegments.join('/');

[pekura]

I would rather stick to windowPath = windowPathSegments.slice(0, nodePathSegments.length).join('/'); because of dynamic path segments. It might work now but in the future after a planned refactoring (because of mutating the navigation data structure that we do not want to happen) it will get broken for sure.

[dariadomagala-sap]

You are right, I reverted my latest commit.