Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add improvements to Luigi Client API comments and annotations #262

Merged
merged 5 commits into from
Dec 3, 2018

Conversation

bszwarc
Copy link
Contributor

@bszwarc bszwarc commented Nov 30, 2018

Description

Changes proposed in this pull request:

  • Add improvements to Luigi API docs

Related issues

See #170

client/luigi-client.js Outdated Show resolved Hide resolved
client/luigi-client.js Outdated Show resolved Hide resolved
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments.

Copy link
Contributor

@dariadomagala-sap dariadomagala-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, just one tiny comment ;)

client/luigi-client.js Show resolved Hide resolved
@bszwarc bszwarc merged commit bf1d8ef into SAP:master Dec 3, 2018
@bszwarc bszwarc deleted the issue-170-apidoc branch December 3, 2018 11:15
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
* Add improvements to Luigi Client API comments and annotations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants