It is not possible to have a root node with empty path segment and a view #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ec5f47c.
…ing or a slash - fix.
pekura
requested review from
antiheld,
dariadomagala-sap,
hardl,
jesusreal,
kwiatekus,
maxmarkus,
parostatkiem-zz and
y-kkamil
as code owners
…h-empty-path-segment-and-a-view
|
OK, maybe the navigation structure you provide is not as expected. This only works if you provide the nodes not as an array but as a single root node object (with children) where pathSegment is set to empty string. Maybe you provide an array (as we always had it like that in our examples, but now you can actually specify the tree from the root node (which is only one and that is why it may not be an array)). |
|
@pekura You are right. Unfortunately I need an additional node in the top-navigation, so I need to have two main nodes, and because of that it won't work for me. |
jesusreal
reviewed
Dec 19, 2018
There was a problem hiding this comment.
I created this patch diff-proposal.zip and when navigating to http://localhost:4200 this is what I get
What am I testing wrongly?
jesusreal
reviewed
Dec 19, 2018
jesusreal
approved these changes
Dec 21, 2018
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
…view (SAP#299) It is not possible to have a root node with empty path segment and a view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not possible to set the root node's path segment as an empty string or a slash - fix.