Icons in navigation nodes #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cons-in-navigation-nodes # Conflicts: # core/src/navigation/LeftNav.html
parostatkiem-zz
requested review from
antiheld,
dariadomagala-sap,
hardl,
jesusreal,
kwiatekus,
maxmarkus,
pekura and
y-kkamil
as code owners
parostatkiem-zz
requested review from
bszwarc,
kazydek,
klaudiagrz and
tomekpapiernik
as code owners
tomekpapiernik
suggested changes
Dec 24, 2018
docs/navigation-configuration.md
Outdated
| @@ -247,6 +247,7 @@ The node parameters are as follows: | |||
| - **loadingIndicator.enabled** shows a loading indicator when switching between micro front-ends. If you have a fast micro front-end, you can disable this feature to prevent flickering of the loading indicator. This parameter is enabled by default. | |||
| - **loadingIndicator.hideAutomatically** disables the automatic hiding of the loading indicator once the micro front-end is loaded. It is only considered if the loading indicator is enabled. It does not apply if the loading indicator is activated manually with the `LuigiClient.uxManager().showLoadingIndicator()` function. If the loading indicator is enabled and automatic hiding is disabled, use `LuigiClient.uxManager().hideLoadingIndicator()` to hide it manually in your micro front-end during the startup. This parameter is enabled by default. | |||
| - **viewGroup** defines a group of views in the same domain sharing a common security context. This improves performance through reusing the frame. Use **viewGroup** only for the views that use path routing internally. | |||
| - **icon** is the name if an icon from [OpenUI](https://openui5.hana.ondemand.com/1.40.10/iconExplorer.html) that will be shown next to the Node's label (side navigation) or instead of it (top navigation). | |||
There was a problem hiding this comment.
Suggested change
| - **icon** is the name if an icon from [OpenUI](https://openui5.hana.ondemand.com/1.40.10/iconExplorer.html) that will be shown next to the Node's label (side navigation) or instead of it (top navigation). | |
| - **icon** is the name if an icon from the [OpenUI](https://openui5.hana.ondemand.com/1.40.10/iconExplorer.html) displayed next to the Node label in the side navigation or instead of the label in the top navigation. |
There was a problem hiding this comment.
Additionally: ...is the name of an icon
dariadomagala-sap
approved these changes
Dec 27, 2018
docs/navigation-configuration.md
Outdated
| @@ -247,6 +247,7 @@ The node parameters are as follows: | |||
| - **loadingIndicator.enabled** shows a loading indicator when switching between micro front-ends. If you have a fast micro front-end, you can disable this feature to prevent flickering of the loading indicator. This parameter is enabled by default. | |||
| - **loadingIndicator.hideAutomatically** disables the automatic hiding of the loading indicator once the micro front-end is loaded. It is only considered if the loading indicator is enabled. It does not apply if the loading indicator is activated manually with the `LuigiClient.uxManager().showLoadingIndicator()` function. If the loading indicator is enabled and automatic hiding is disabled, use `LuigiClient.uxManager().hideLoadingIndicator()` to hide it manually in your micro front-end during the startup. This parameter is enabled by default. | |||
| - **viewGroup** defines a group of views in the same domain sharing a common security context. This improves performance through reusing the frame. Use **viewGroup** only for the views that use path routing internally. | |||
| - **icon** is the name if an icon from [OpenUI](https://openui5.hana.ondemand.com/1.40.10/iconExplorer.html) that will be shown next to the Node's label (side navigation) or instead of it (top navigation). | |||
There was a problem hiding this comment.
Additionally: ...is the name of an icon
| cy.get('button[title="Settings"]').should('contain', ''); | ||
| }); | ||
|
|
||
| it('Icon instead of label in LeftNav', () => { |
There was a problem hiding this comment.
Icon with label in the left nav :)
core/src/navigation/LeftNav.html
Outdated
| {node.label} | ||
| {#if node.externalLink && node.externalLink.url} | ||
| <span class="sap-icon--action sap-icon--s"></span> | ||
| <span class="sap-icon--action sap-icon--s external-link"></span> |
There was a problem hiding this comment.
this additional class is not used anywhere
…cons-in-navigation-nodes # Conflicts: # core/src/navigation/TopNav.html
|
please add support for custom icons loaded from external url in addition to OpenUI5 icons |
tomekpapiernik
approved these changes
Jan 2, 2019
|
👍 |
|
If some nodes are without an icon the labels are not aligned any more:
|
|
The icon for the "Keep Selected Example" is confusing, it makes you think that it is some kind of expandable group node; it is just our sample app but still.. |
adapted spacing and icon sizes based on Philipp's input
pekura
approved these changes
Jan 7, 2019
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* Implement icons in left nav * Add e2e tests * Update docu * Add ability to set custom node icons * Implement image icons in side nav groups * Reorganize icon styling & improve nav links alignment * added more icons to the sample config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
iconproperty can now be used in Top and Side navigation configurationRelated issue(s)