Redirect from root node to first child #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-kkamil
requested review from
antiheld,
dariadomagala-sap,
hardl,
jesusreal,
kwiatekus,
maxmarkus and
pekura
as code owners
kwiatekus
suggested changes
Sep 7, 2018
added 2 commits
September 7, 2018 11:46
…i into default-nodes-improvements
y-kkamil
requested review from
kazydek,
klaudiagrz and
tomekpapiernik
as code owners
kwiatekus
approved these changes
Sep 7, 2018
…odes-improvements
…i into default-nodes-improvements
kazydek
reviewed
Sep 7, 2018
docs/navigation-configuration.md
Outdated
| @@ -60,9 +60,10 @@ window.Luigi.setConfig({ | |||
| - **pathSegment** specifies the partial URL of the current segment. A static settings example reflects `luigidomain.test/settings`, while a dynamic one loads on any other value. | |||
| - **label** contains the display name of the navigation Node. | |||
| - **hideFromNav** shows or hides a navigation Node. You can still navigate to the Node but it will not show up in the top or left pane. | |||
| - **viewUrl** contains the URL or path to a view that renders when entering the navigation Node. Use either a full URL or a relative path. This value may consist of variables if you have specified a **navigationContext** with a dynamic **pathSegment**. | |||
| - **viewUrl** contains the URL or path to a view that renders when entering the navigation Node. Use either a full URL or a relative path. This value may consist of variables if you have specified a **navigationContext** with a dynamic **pathSegment**. If **viewUrl** is undefined, Luigi activates the child node specified in **defaultChildNode**. When both **viewUrl** and **defaultChildNode** are undefined, Luigi opens first child of the current node. | |||
docs/navigation-configuration.md
Outdated
| - **navigationContext** contains a named Node that is mainly for use in combination with a dynamic **pathSegment** to start navigation from a dynamic Node using ` LuigiClient.navigationManager().fromContext('contextname')`. | ||
| - **context** sends the specified object as context to the view. Use this parameter in combination with the dynamic **pathSegment** to receive the context through the context listeners of **Luigi client**. This is an alternative to using the dynamic value in the **viewUrl**. | ||
| - **defaultChildNode** sets the child node that will be automatically activated if the current node has no **viewUrl** defined. Provide the **pathSegment** of the child node you want to activate as a string. |
There was a problem hiding this comment.
- that will be automatically activated ->
that the system activates automaticallyor whatever activates it (active voice in general) - Provide the pathSegment -> IMHO it should be either
**pathSegment**orthe **pathSegment** parameter(that refers to the whole text in general).
…i into default-nodes-improvements
kazydek
approved these changes
Sep 7, 2018
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* Redirect from root node to first child * rename defaultPathSegment to defaultChildNode * docu added * changes in the readme after code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support for redirection from root node ('') to first child.
Issue link
Fixes #47