Webpack for LuigiClient #325

parostatkiem-zz · 2019-01-08T15:34:55Z

Description

`lerna bootstrap` required in `/client`

Changes proposed in this pull request:

bundle LuigiClient with Babel using preset-env
add 2 new commands for /client: npm run bundle and npm run bundle-develop
remove manual UMD wrapper from the source file (it's now added by Webpack in slightly changed form)
source file code is not changed (except removing UMD part). We should introduce class-approach and other things in a separate task. For now, an object is exported. It's up to us how that object is created.

Related issue(s)

dariadomagala-sap

Right now, we should probably publish only the transpiled /public folder, so we need package.json and readme.md there as well (look how it's solved in core).

dariadomagala-sap

Please also add the client/public to the lerna.json file.

dariadomagala-sap · 2019-01-10T08:38:07Z

client/package.json

@@ -2,8 +2,10 @@
  "name": "@kyma-project/luigi-client",


Please change the name of this package. It won't be the @kyma-project/luigi-client package anymore, the transpiled version will be.

…ebpack-for-Client # Conflicts: # core/examples/luigi-sample-angular/package-lock.json

bszwarc

Small comment

bszwarc · 2019-01-10T13:43:30Z

client/public/README.md

+
+If you want to try Luigi out, see the [examples](https://github.com/kyma-project/luigi/tree/master/core/examples).
+
+For documentation on Luigi Core, see [Luigi documentation](https://github.com/kyma-project/luigi/tree/master/docs).


Maybe we can change it to:

For more documentation on Luigi framework, see [Luigi documentation](https://github.com/kyma-project/luigi/tree/master/docs).

because it is not only about Luigi Core. 🤔

dariadomagala-sap

Now I get
GET http://localhost:4200/luigi-client/luigi-client.bundle.js net::ERR_ABORTED 404 (Not Found)

maxmarkus

Docu generation is not working, rest is fine.

maxmarkus · 2019-01-10T16:20:41Z

client/package.json

  "scripts": {
+    "bundle": "webpack --mode production",
+    "bundle-develop": "webpack --mode development --watch",
    "test": "echo \"Error: no test specified\" && exit 1",
    "docu": "npm run docu:validate && npm run docu:generate:section",
    "docu:generate:new-file": "documentation build luigi-client.js -f md --markdown-toc=false -o ../docs/luigi-client-api.md",


Documentation is not working (path references and some babel errors)

…ebpack-for-Client # Conflicts: # client/luigi-client.js

…ebpack-for-Client # Conflicts: # client/package-lock.json # core/package-lock.json

parostatkiem-zz · 2019-01-15T08:10:04Z

The output file is now client/luigi-client.js to keep backwards compatibility. The source file is client/src/luigi-client.js (of course it can be extended to many files via import).

dariadomagala-sap

Right now we are publishing regular luigi client + bundled luigi client. I don't think that's a good approach.

dariadomagala-sap · 2019-01-15T10:54:15Z

client/.npmignore

@@ -0,0 +1 @@
+/luigi-client.js


But.. we want to publish luigi-client.js. We don't want to publish /src.

dariadomagala-sap · 2019-01-15T10:54:41Z

client/package.json

@@ -16,6 +16,7 @@
  ],
  "main": "luigi-client.js",
  "scripts": {
+    "install": "npm run bundle",


What is this script for?

…ebpack-for-Client # Conflicts: # core/examples/luigi-sample-angular/package-lock.json # core/package-lock.json

…ebpack-for-Client # Conflicts: # core/examples/luigi-sample-angular/package-lock.json # core/examples/luigi-sample-angular/package.json # core/package-lock.json

bszwarc · 2019-01-18T09:21:11Z

docs/luigi-client-api.md

@@ -205,4 +211,4 @@ This method informs the main application that there are unsaved changes in the c

 #### Parameters

-   `isDirty` **[boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Boolean)** indicates if there are any unsaved changes on the current page or in the component
+-   `isDirty` **[boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Boolean)** tells if there are any unsaved changes on the current page or component


Revert to the original version in the js file:

`isDirty` **[boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Boolean)** indicates if there are any unsaved changes on the current page or in the component

* Bundle LuigiClient with Babel * Bump luigi-client version * Update documentation * remove object.assign polyfill * Update path in external views * Update package-locks & gitignore * Make only bundled version to be published on NPM

parostatkiem-zz added 2 commits January 8, 2019 15:43

Bundle LuigiClient with Babel

4a36f6d

fix Angular's assets path

76dc1f5

parostatkiem-zz added enhancement New feature or request area/luigi labels Jan 8, 2019

parostatkiem-zz requested review from antiheld, dariadomagala-sap, hardl, jesusreal, kwiatekus, maxmarkus, pekura and y-kkamil as code owners January 8, 2019 15:34

dariadomagala-sap self-assigned this Jan 9, 2019

dariadomagala-sap suggested changes Jan 9, 2019

View reviewed changes

Add separate readme and package.json to /public

0c19d7b

parostatkiem-zz requested review from bszwarc, kazydek, klaudiagrz and tomekpapiernik as code owners January 9, 2019 10:03

bszwarc added the area/documentation label Jan 10, 2019

bszwarc self-assigned this Jan 10, 2019

dariadomagala-sap suggested changes Jan 10, 2019

View reviewed changes

parostatkiem-zz added 3 commits January 10, 2019 14:30

Merge branch 'master' of https://github.com/kyma-project/luigi into w…

30b3f6a

…ebpack-for-Client # Conflicts: # core/examples/luigi-sample-angular/package-lock.json

Update lerna.json

5132cfb

Update luigi-client-private package.json

13deed7

bszwarc reviewed Jan 10, 2019

View reviewed changes

Update readme

ad5041d

dariadomagala-sap suggested changes Jan 10, 2019

View reviewed changes

maxmarkus self-assigned this Jan 10, 2019

maxmarkus suggested changes Jan 10, 2019

View reviewed changes

parostatkiem-zz added 2 commits January 11, 2019 09:30

Update documentation

710b65a

Fix Angular's asset alias

e8bddac

dariadomagala-sap approved these changes Jan 11, 2019

View reviewed changes

remove object.assign polyfill

7373a54

maxmarkus approved these changes Jan 11, 2019

View reviewed changes

Merge branch 'master' of https://github.com/kyma-project/luigi into w…

10b62bf

…ebpack-for-Client # Conflicts: # client/luigi-client.js

jesusreal mentioned this pull request Jan 14, 2019

Update Bamboo plan for Luigi #338

Closed

parostatkiem-zz added the WIP Work in progress label Jan 14, 2019

parostatkiem-zz added 2 commits January 15, 2019 08:30

Abandon 'public' folder to keep backwards compatibility

e5ce709

Update path in external views

fc8bb68

parostatkiem-zz removed the WIP Work in progress label Jan 15, 2019

parostatkiem-zz added 2 commits January 15, 2019 09:01

Merge branch 'master' of https://github.com/kyma-project/luigi into w…

ee996dd

…ebpack-for-Client # Conflicts: # client/package-lock.json # core/package-lock.json

Update package-locks & gitignore

8173932

dariadomagala-sap suggested changes Jan 15, 2019

View reviewed changes

parostatkiem-zz added 2 commits January 15, 2019 11:33

Update AngularExample to use newest Luigi

e628f58

Prepare LuigiClient to be published at NPM

30f4ee2

dariadomagala-sap reviewed Jan 15, 2019

View reviewed changes

Make only bundled version to be published on NPM

8141298

dariadomagala-sap approved these changes Jan 16, 2019

View reviewed changes

parostatkiem-zz added 2 commits January 17, 2019 10:34

Merge branch 'master' of https://github.com/kyma-project/luigi into w…

cb1c904

…ebpack-for-Client # Conflicts: # core/examples/luigi-sample-angular/package-lock.json # core/package-lock.json

Merge branch 'master' of https://github.com/kyma-project/luigi into w…

ba0ba96

…ebpack-for-Client # Conflicts: # core/examples/luigi-sample-angular/package-lock.json # core/examples/luigi-sample-angular/package.json # core/package-lock.json

bszwarc reviewed Jan 18, 2019

View reviewed changes

Update docu

c571638

bszwarc approved these changes Jan 18, 2019

View reviewed changes

parostatkiem-zz merged commit f77f41f into SAP:master Jan 18, 2019

parostatkiem-zz deleted the webpack-for-Client branch January 18, 2019 09:27

misappi unassigned bszwarc and dariadomagala-sap May 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Webpack for LuigiClient #325

Webpack for LuigiClient #325

parostatkiem-zz commented Jan 8, 2019

dariadomagala-sap left a comment

dariadomagala-sap left a comment

dariadomagala-sap Jan 10, 2019

bszwarc left a comment

bszwarc Jan 10, 2019

dariadomagala-sap left a comment

maxmarkus left a comment

maxmarkus Jan 10, 2019

parostatkiem-zz commented Jan 15, 2019 •

edited

Loading

dariadomagala-sap left a comment

dariadomagala-sap Jan 15, 2019

dariadomagala-sap Jan 15, 2019

bszwarc Jan 18, 2019


		If you want to try Luigi out, see the [examples](https://github.com/kyma-project/luigi/tree/master/core/examples).

		For documentation on Luigi Core, see [Luigi documentation](https://github.com/kyma-project/luigi/tree/master/docs).

		@@ -0,0 +1 @@
		/luigi-client.js

Webpack for LuigiClient #325

Webpack for LuigiClient #325

Conversation

parostatkiem-zz commented Jan 8, 2019

lerna bootstrap required in /client

dariadomagala-sap left a comment

Choose a reason for hiding this comment

dariadomagala-sap left a comment

Choose a reason for hiding this comment

dariadomagala-sap Jan 10, 2019

Choose a reason for hiding this comment

bszwarc left a comment

Choose a reason for hiding this comment

bszwarc Jan 10, 2019

Choose a reason for hiding this comment

dariadomagala-sap left a comment

Choose a reason for hiding this comment

maxmarkus left a comment

Choose a reason for hiding this comment

maxmarkus Jan 10, 2019

Choose a reason for hiding this comment

parostatkiem-zz commented Jan 15, 2019 • edited Loading

dariadomagala-sap left a comment

Choose a reason for hiding this comment

dariadomagala-sap Jan 15, 2019

Choose a reason for hiding this comment

dariadomagala-sap Jan 15, 2019

Choose a reason for hiding this comment

bszwarc Jan 18, 2019

Choose a reason for hiding this comment

`lerna bootstrap` required in `/client`

parostatkiem-zz commented Jan 15, 2019 •

edited

Loading