es5-for-luigi #33
Merged
es5-for-luigi #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-kkamil
requested review from
antiheld and
dariadomagala-sap
as code owners
y-kkamil
requested review from
hardl,
jesusreal,
kazydek,
klaudiagrz,
kwiatekus,
maxmarkus,
pekura and
tomekpapiernik
as code owners
klaudiagrz
approved these changes
Sep 5, 2018
dariadomagala-sap
suggested changes
Sep 7, 2018
client/README.md
Outdated
| ``` | ||
| or | ||
| ```javascript | ||
| import * as LuigiClient from '@kyma-project/luigi-client'; |
There was a problem hiding this comment.
import LuigiClient from '@kyma-project/luigi-client'
should be enough.
client/luigi-client.js
Outdated
| @@ -1,307 +1,307 @@ | |||
| (function (root, factory) { // UMD wrapper | |||
| if (typeof define === 'function' && define.amd) { | |||
| define([], factory); | |||
There was a problem hiding this comment.
From AMD documentation:
define(id?, dependencies?, factory);
Since dependencies are not required, we don't need this empty array of dependencies.
dariadomagala-sap
approved these changes
Sep 10, 2018
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* es5-for-luigi * change import for luigi-client, as it is now a commonjs module * package-lock update * create a UMD for client lib * change import syntax * change amd definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.