Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce changelog file #34

Merged
merged 22 commits into from
Sep 11, 2018
Merged

Conversation

jesusreal
Copy link
Contributor

@jesusreal jesusreal commented Sep 4, 2018

Confirm these statements before you submit your pull request:

  • I have read and submitted the required Contributor Licence Agreements.
  • This pull request follows the contributing guidelines, recommended Git workflow, and templates.
  • I have tested my changes.
  • I have updated the relevant documentation.

Description

Changes proposed in this pull request:

  • Introduce changelog file

Issue link:
Fixes #48

Copy link

@kazydek kazydek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it has been decided that the changelog will be created based on labels. The tool was also chosen for that purpose. Please, contact @jose-cortina for details. Thanks.

CHANGELOG.md Outdated
Generate changelog using lerna-changelog tool.


Types of changes are detected based on PR labels and are mapped to sections as per configuration in the package.json
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lerna-changelog tool detects changes based on PR labels and maps them to sections as per the configuration in the package.json file.

CHANGELOG.md Outdated
<!-- #and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). -->

<!--
Generate changelog using lerna-changelog tool.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generate the changelog using the lerna-changelog tool.

CHANGELOG.md Outdated
@@ -0,0 +1,83 @@
# Changelog

<!-- , -->
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this line needed for?

CHANGELOG.md Outdated
# Changelog

<!-- , -->
<!-- #and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). -->
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can just write: This project adheres to Semantic Versioning: https://semver.org/spec/v2.0.0.html. ? Since it is a comment, markdown formatting is not needed here.

CHANGELOG.md Outdated
<!--
Generate the changelog the using lerna-changelog tool, i.e

./node_modules/lerna-changelog/bin/cli.js --ignoreCommitters (--from core-0.3.0)
Copy link

@kazydek kazydek Sep 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generate the changelog the using lerna-changelog tool, i.e ./node_modules/lerna-changelog/bin/cli.js --ignoreCommitters (--from core-0.3.0) -> Generate the changelog using the lerna-changelog tool. For example, ./node_modules/lerna-changelog/bin/cli.js --ignoreCommitters (--from core-0.3.0).

CHANGELOG.md Outdated

<!--
Generate the changelog using the lerna-changelog tool.
Run the following command to generate changelog content for pull requests that were merged since the time when the last git tag was created.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pull requests that have been merged since (since -> present perfect) and if you say Run the following command I guess it would be better to add the sentence with the : rather than .?

CHANGELOG.md Outdated

./node_modules/lerna-changelog/bin/cli.js --ignoreCommiters

You can also generate changelog content corresponding to pull requests that were merged in between particular git tags.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Can you finish with the : as well? or add sth like Run this command: after the existing sentence.

@kwiatekus kwiatekus merged commit 80f94b8 into SAP:master Sep 11, 2018
@kwiatekus kwiatekus deleted the introduce-changelog-file branch September 11, 2018 09:13
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
* Introduce changelog file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants