-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce changelog file #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it has been decided that the changelog will be created based on labels. The tool was also chosen for that purpose. Please, contact @jose-cortina for details. Thanks.
CHANGELOG.md
Outdated
Generate changelog using lerna-changelog tool. | ||
|
||
|
||
Types of changes are detected based on PR labels and are mapped to sections as per configuration in the package.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lerna-changelog tool detects changes based on PR labels and maps them to sections as per the configuration in the package.json file.
CHANGELOG.md
Outdated
<!-- #and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). --> | ||
|
||
<!-- | ||
Generate changelog using lerna-changelog tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generate the changelog using the lerna-changelog tool.
CHANGELOG.md
Outdated
@@ -0,0 +1,83 @@ | |||
# Changelog | |||
|
|||
<!-- , --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this line needed for?
CHANGELOG.md
Outdated
# Changelog | ||
|
||
<!-- , --> | ||
<!-- #and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we can just write: This project adheres to Semantic Versioning: https://semver.org/spec/v2.0.0.html.
? Since it is a comment, markdown formatting is not needed here.
CHANGELOG.md
Outdated
<!-- | ||
Generate the changelog the using lerna-changelog tool, i.e | ||
|
||
./node_modules/lerna-changelog/bin/cli.js --ignoreCommitters (--from core-0.3.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generate the changelog the using lerna-changelog tool, i.e ./node_modules/lerna-changelog/bin/cli.js --ignoreCommitters (--from core-0.3.0) -> Generate the changelog using the lerna-changelog tool. For example, ./node_modules/lerna-changelog/bin/cli.js --ignoreCommitters (--from core-0.3.0).
CHANGELOG.md
Outdated
|
||
<!-- | ||
Generate the changelog using the lerna-changelog tool. | ||
Run the following command to generate changelog content for pull requests that were merged since the time when the last git tag was created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pull requests that have been merged since
(since -> present perfect) and if you say Run the following command
I guess it would be better to add the sentence with the :
rather than .
?
CHANGELOG.md
Outdated
|
||
./node_modules/lerna-changelog/bin/cli.js --ignoreCommiters | ||
|
||
You can also generate changelog content corresponding to pull requests that were merged in between particular git tags. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. Can you finish with the :
as well? or add sth like Run this command:
after the existing sentence.
* Introduce changelog file
Confirm these statements before you submit your pull request:
Description
Changes proposed in this pull request:
Issue link:
Fixes #48