Fix preserve views node params #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariadomagala-sap
requested review from
antiheld,
hardl,
jesusreal,
kwiatekus,
maxmarkus,
parostatkiem-zz,
pekura and
y-kkamil
as code owners
core/src/App.html
Outdated
| @@ -115,8 +115,10 @@ | |||
| if (data.params.preserveView) { | |||
| const pv = component.get().preservedViews; | |||
| const nextPath = buildPath(component, data.params); | |||
| const pathUrlRaw = component.get().pathUrlRaw; | |||
There was a problem hiding this comment.
The solution works well 👍
I can see you're calling component.get() multiple times. Wouldn't it be better to use
const {pathUrlRaw, preservedViews, currentNode} = component.get();I'm not sure but there might be also a performance advantage for this approach.
jesusreal
suggested changes
Jan 16, 2019
core/src/services/routing.js
Outdated
| @@ -236,6 +237,7 @@ export const handleRouteChange = async (path, component, node, config) => { | |||
| pathParams, | |||
| isolateView, | |||
| viewGroup, | |||
| pathUrlRaw, | |||
There was a problem hiding this comment.
As the only thing we are doing with patUrlRaw is extract the url params in App.html, why don't we just save the url params instead?
parostatkiem-zz
approved these changes
Jan 16, 2019
jesusreal
approved these changes
Jan 16, 2019
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Fixes preserve views node params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Fixes : #337