Empty navigation category should not be shown #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ec5f47c.
pekura
requested review from
antiheld,
dariadomagala-sap,
hardl and
jesusreal
as code owners
pekura
requested review from
kwiatekus,
maxmarkus,
parostatkiem-zz and
y-kkamil
as code owners
JohannesDoberer
approved these changes
Jan 18, 2019
hardl
approved these changes
Jan 18, 2019
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Empty navigation category should not be shown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty navigation category should not be shown even if it contains nodes with hiddenFromNav setting and it should keep properties (like icon) of the category even if defined on a node with hiddenFromNav setting.